-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose TypeScript definitions so that they are easily accessible #5
Comments
The Do you think it would be helpful if I published the |
Nop, but the way you use to make your import are outdated...
I'll maybe make a PR here this week-end to update definitions and on DefinitelyTyped to publish them, if it's okay to you :) |
What do you mean? If there's something that I can be doing better, I'd be happy to hear it -- I am not by any means a TypeScript expert.
I was resisting doing that because so few people use this module at the moment -- most people who are on ev3dev are using Python. So I just didn't want to "pollute" DefinitelyTyped until there were more people that would benefit from it. But I'd be happy to try to get ev3dev-lang-js published there if you think it's useful.
Of course! I'll always accept PRs. But please don't open a PR against DefinitelyTyped yet so that we can make sure that the import/exports are how they should be and have some time to discuss. |
Try changing your TypeScript settings for the project to target EcmaScript 5 instead. Because newer versions of Node don't support old ARM processors, we can't run ES6 on the EV3 😢 If the TypeScript transpiler is nice enough to convert ES6 code into ES5, that shouldn't be a problem; but if it isn't, we will be needing to stick with ES5 features. |
It works, thanks :) |
Hey,
Is there a way to use the module with typescript's import ?
Thanks
The text was updated successfully, but these errors were encountered: