Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug on attachement when updating to cucumberjs 10+ #298

Open
lerhum opened this issue Nov 23, 2023 · 2 comments
Open

bug on attachement when updating to cucumberjs 10+ #298

lerhum opened this issue Nov 23, 2023 · 2 comments

Comments

@lerhum
Copy link

lerhum commented Nov 23, 2023

Environment (please complete the following information):

multiple-cucumber-html-reporter: 3.4.0
Node.js version: v18.17.1
NPM version: 9.6.7
Platform name and version: mac os
Cucumber version: 10.0.1

Describe the bug
In the JSON formatter output of multiple-cucumber-html-reporter, all attachments, including those initially attached as plain text strings, are now Base64 encoded. This uniform encoding approach leads to ambiguity for consumers of the report, as they cannot distinguish whether an attachment was originally a plain text string or a different file format.

To Reproduce
Steps to reproduce the behavior:

just generate a report based on cucumber 10.0.1 with some attachement (json/ text / image)

Expected behavior
The expected behavior was that string attachments would remain as plain text in the JSON formatter output, while other types of attachments would be Base64 encoded. This distinction would enable consumers to easily identify the nature of the attachments without additional processing.

Additional context
To resolve this issue, a decoding mechanism such as atob(embedding.data); should be implemented to correctly decode Base64 attachments before passing them to the report. This would ensure that plain text attachments maintain their original format in the JSON output.

@charleslana
Copy link

Hello, the pull request has not yet been accepted, any feedback to resolve the problem?

@WasiqB
Copy link
Owner

WasiqB commented Dec 17, 2023

Hi @charleslana , the PR has a failing test. Once it gets fixed, we are good to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants