Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!(Internal): 🔥 Removed unused variable #24

Merged
merged 14 commits into from
Mar 8, 2022
Merged

Conversation

WasiqB
Copy link
Member

@WasiqB WasiqB commented Mar 4, 2022

No description provided.

@WasiqB WasiqB self-assigned this Mar 4, 2022
@WasiqB WasiqB linked an issue Mar 4, 2022 that may be closed by this pull request
WasiqB added 13 commits March 4, 2022 11:36
* ✨ Updated API manager

Introduced Builder class of ApiRequest to compose the request and executing the same via ApiManager.execute static method.

* ✅ Added more API tests for different methods.
…x runner

* 🔧 Updated test workflow

Changed test job runner from Linux to Mac OS

* 🔧 Install docker on Mac OS runner

* 🔧 Updated docker install command.

* 💚 Added Selenium Grid lib

Updated workflow to use local Selenium Grid standalone lib to execute test on Safari.

* 💚 Updated Selenium grid start command.

Updated command to redirect logs to null.

* ✅ Added new tests for other browsers

* 💚 Added GitHub token in test job

To fix WebDriverManager Error, added GitHub token env variable.

* ✅ Local Browser tests now executes in parallel
* ✨ Added Opera browser support

* 🔧 Updated test workflow to run tests on Mac OS runner instead of Linux runner

* 🔧 Updated test workflow

Changed test job runner from Linux to Mac OS

* 🔧 Install docker on Mac OS runner

* 🔧 Updated docker install command.

* 💚 Added Selenium Grid lib

Updated workflow to use local Selenium Grid standalone lib to execute test on Safari.

* 💚 Updated Selenium grid start command.

Updated command to redirect logs to null.

* ✅ Added new tests for other browsers

* 💚 Added GitHub token in test job

To fix WebDriverManager Error, added GitHub token env variable.

* ✅ Local Browser tests now executes in parallel

* ✨ Added Opera browser support

* ✅ TestNG xml file name updated.

* ✨ Added Opera browser support

* 🔀 Main branch changes updated correctly.

* 🔧 Attached logs to Selenium Grid standalone for debugging

* ✅ Added Opera Browser tests
* ✨ Added Auto-wait feature for UI

Framework will wait until element is clickable before performing any action, and wait until element is visible before getting any element attributes.

* 🔧 Updated test config files

Updated test-config.json and made tests run in parallel.

* ♻️ NONE waite strategy removed

* 🔧 Updated test workflow to run tests on Mac OS runner instead of Linux runner

* 🔧 Updated test workflow

Changed test job runner from Linux to Mac OS

* 🔧 Install docker on Mac OS runner

* 🔧 Updated docker install command.

* 💚 Added Selenium Grid lib

Updated workflow to use local Selenium Grid standalone lib to execute test on Safari.

* 💚 Updated Selenium grid start command.

Updated command to redirect logs to null.

* ✅ Added new tests for other browsers

* 💚 Added GitHub token in test job

To fix WebDriverManager Error, added GitHub token env variable.

* ✅ Local Browser tests now executes in parallel

* ✨ Added Opera browser support (#32)

* ✨ Added Opera browser support

* 🔧 Updated test workflow to run tests on Mac OS runner instead of Linux runner

* 🔧 Updated test workflow

Changed test job runner from Linux to Mac OS

* 🔧 Install docker on Mac OS runner

* 🔧 Updated docker install command.

* 💚 Added Selenium Grid lib

Updated workflow to use local Selenium Grid standalone lib to execute test on Safari.

* 💚 Updated Selenium grid start command.

Updated command to redirect logs to null.

* ✅ Added new tests for other browsers

* 💚 Added GitHub token in test job

To fix WebDriverManager Error, added GitHub token env variable.

* ✅ Local Browser tests now executes in parallel

* ✨ Added Opera browser support

* ✅ TestNG xml file name updated.

* ✨ Added Opera browser support

* 🔀 Main branch changes updated correctly.

* 🔧 Attached logs to Selenium Grid standalone for debugging

* ✅ Added Opera Browser tests

* ✨ Added Auto-wait feature for UI

Framework will wait until element is clickable before performing any action, and wait until element is visible before getting any element attributes.

* 🔧 Updated test config files

Updated test-config.json and made tests run in parallel.

* ♻️ NONE waite strategy removed
One test failing on CI due to implicit wait = 1
@WasiqB WasiqB marked this pull request as ready for review March 8, 2022 11:46
@WasiqB WasiqB requested a review from mfaisalkhatri March 8, 2022 11:53
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.7% 83.7% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@mfaisalkhatri mfaisalkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mfaisalkhatri mfaisalkhatri merged commit 8da56b2 into main Mar 8, 2022
@mfaisalkhatri mfaisalkhatri deleted the issue-5 branch March 8, 2022 14:03
@WasiqB WasiqB changed the title 🔥 Removed unused variable refactor!(Internal): 🔥 Removed unused variable Jul 1, 2022
@WasiqB WasiqB added 💅 pr: polish PR which refactors the code 💥 pr: breaking change PR which adds breaking changes and removed 💅 pr: polish PR which refactors the code labels Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 pr: breaking change PR which adds breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logging with Log4j2
2 participants