-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!(Internal): 🔥 Removed unused variable #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
* ✨ Updated API manager Introduced Builder class of ApiRequest to compose the request and executing the same via ApiManager.execute static method. * ✅ Added more API tests for different methods.
…x runner * 🔧 Updated test workflow Changed test job runner from Linux to Mac OS * 🔧 Install docker on Mac OS runner * 🔧 Updated docker install command. * 💚 Added Selenium Grid lib Updated workflow to use local Selenium Grid standalone lib to execute test on Safari. * 💚 Updated Selenium grid start command. Updated command to redirect logs to null. * ✅ Added new tests for other browsers * 💚 Added GitHub token in test job To fix WebDriverManager Error, added GitHub token env variable. * ✅ Local Browser tests now executes in parallel
* ✨ Added Opera browser support * 🔧 Updated test workflow to run tests on Mac OS runner instead of Linux runner * 🔧 Updated test workflow Changed test job runner from Linux to Mac OS * 🔧 Install docker on Mac OS runner * 🔧 Updated docker install command. * 💚 Added Selenium Grid lib Updated workflow to use local Selenium Grid standalone lib to execute test on Safari. * 💚 Updated Selenium grid start command. Updated command to redirect logs to null. * ✅ Added new tests for other browsers * 💚 Added GitHub token in test job To fix WebDriverManager Error, added GitHub token env variable. * ✅ Local Browser tests now executes in parallel * ✨ Added Opera browser support * ✅ TestNG xml file name updated. * ✨ Added Opera browser support * 🔀 Main branch changes updated correctly. * 🔧 Attached logs to Selenium Grid standalone for debugging * ✅ Added Opera Browser tests
* ✨ Added Auto-wait feature for UI Framework will wait until element is clickable before performing any action, and wait until element is visible before getting any element attributes. * 🔧 Updated test config files Updated test-config.json and made tests run in parallel. * ♻️ NONE waite strategy removed * 🔧 Updated test workflow to run tests on Mac OS runner instead of Linux runner * 🔧 Updated test workflow Changed test job runner from Linux to Mac OS * 🔧 Install docker on Mac OS runner * 🔧 Updated docker install command. * 💚 Added Selenium Grid lib Updated workflow to use local Selenium Grid standalone lib to execute test on Safari. * 💚 Updated Selenium grid start command. Updated command to redirect logs to null. * ✅ Added new tests for other browsers * 💚 Added GitHub token in test job To fix WebDriverManager Error, added GitHub token env variable. * ✅ Local Browser tests now executes in parallel * ✨ Added Opera browser support (#32) * ✨ Added Opera browser support * 🔧 Updated test workflow to run tests on Mac OS runner instead of Linux runner * 🔧 Updated test workflow Changed test job runner from Linux to Mac OS * 🔧 Install docker on Mac OS runner * 🔧 Updated docker install command. * 💚 Added Selenium Grid lib Updated workflow to use local Selenium Grid standalone lib to execute test on Safari. * 💚 Updated Selenium grid start command. Updated command to redirect logs to null. * ✅ Added new tests for other browsers * 💚 Added GitHub token in test job To fix WebDriverManager Error, added GitHub token env variable. * ✅ Local Browser tests now executes in parallel * ✨ Added Opera browser support * ✅ TestNG xml file name updated. * ✨ Added Opera browser support * 🔀 Main branch changes updated correctly. * 🔧 Attached logs to Selenium Grid standalone for debugging * ✅ Added Opera Browser tests * ✨ Added Auto-wait feature for UI Framework will wait until element is clickable before performing any action, and wait until element is visible before getting any element attributes. * 🔧 Updated test config files Updated test-config.json and made tests run in parallel. * ♻️ NONE waite strategy removed
One test failing on CI due to implicit wait = 1
Kudos, SonarCloud Quality Gate passed! |
mfaisalkhatri
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.