Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(workflow): 🚀 added publish workflow to deploy to Maven central #66

Merged
merged 9 commits into from
Jun 10, 2022
Merged

ci(workflow): 🚀 added publish workflow to deploy to Maven central #66

merged 9 commits into from
Jun 10, 2022

Conversation

WasiqB
Copy link
Member

@WasiqB WasiqB commented May 13, 2022 •
edited
Loading

Closes #14

Type of changes?

  • Bug fixes: Non-breaking change which fixes an issue
  • New feature: Non-breaking change which adds a new feature
  • Performance improvement: Non-breaking change which improves performance
  • Documentation: Non-breaking change which improves documentation
  • Other: Non-breaking change which does not fit into the above categories
  • Breaking change: A breaking change which requires a new version of the library

Checklist for Java project

  • Change not related to Java project

Following checklists are optional if above checkbox is selected:

  • Copyright banner comment added to newly added files, except *.md, *.yml, *.json?
  • Proper JavaDoc updated in main and test classes for all public classes and methods?
  • Tests added for changes?
  • Tests are passing locally?
  • Check style checks are passing locally?
  • Test coverage is at least 80% for newly added changes?
  • There are no SonarCloud issues?
  • README updated? (if applicable)
  • Documentation website updated for the PR raised?

Checklist for Website

  • Change not related to Website project

Following is optional if above checkbox is selected:

  • Lint check passes locally?
  • Prettier check passes locally?
  • Build command working fine locally?

Reviewers

@WasiqBhamla/boyka-core

IMPORTANT: Make sure to check the Allow edits from maintainers box below this window

@WasiqB WasiqB force-pushed the issue-14 branch 2 times, most recently from 6e0c1f0 to f1c9cf6 Compare May 23, 2022 14:54
@WasiqB WasiqB self-assigned this Jun 7, 2022
@WasiqB WasiqB marked this pull request as ready for review June 7, 2022 16:58
@WasiqB WasiqB requested a review from a team as a code owner June 7, 2022 16:58
@WasiqB WasiqB requested a review from mfaisalkhatri June 7, 2022 16:58
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@WasiqB WasiqB merged commit 095a554 into main Jun 10, 2022
@WasiqB WasiqB deleted the issue-14 branch June 10, 2022 05:09
@WasiqB WasiqB added the 🏠 pr: internal PR which adds internal framework changes label Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfaisalkhatri mfaisalkhatri Awaiting requested review from mfaisalkhatri mfaisalkhatri is a code owner automatically assigned from BoykaFramework/boyka-core

Assignees

@WasiqB WasiqB

Labels
🏠 pr: internal PR which adds internal framework changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub workflow to deploy library to Maven central
2 participants
@WasiqB @diogormendes