Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): ✨ add method to verify header and update documentation #89

Merged
merged 1 commit into from
Jun 18, 2022

Conversation

MakodeAjay
Copy link
Contributor

@MakodeAjay MakodeAjay commented Jun 18, 2022

Closes: #53

Type of changes?

  • Bug fixes: Non-breaking change which fixes an issue
  • New feature: Non-breaking change which adds a new feature
  • Performance improvement: Non-breaking change which improves performance
  • Documentation: Non-breaking change which improves documentation
  • Other: Non-breaking change which does not fit into the above categories
  • Breaking change: A breaking change which requires a new version of the library

Checklist for Java project

  • Change not related to Java project

Following checklists are optional if above checkbox is selected:

  • Copyright banner comment added to newly added files, except *.md, *.yml, *.json?
  • Proper JavaDoc updated in main and test classes for all public classes and methods?
  • Tests added for changes?
  • Tests are passing locally?
  • Check style checks are passing locally?
  • Test coverage is at least 80% for newly added changes?
  • There are no SonarCloud issues?
  • README updated? (if applicable)
  • Documentation website updated for the PR raised?

Checklist for Website

  • Change not related to Website project

Following is optional if above checkbox is selected:

  • Lint check passes locally?
  • Prettier check passes locally?
  • Build command working fine locally?

Reviewers

@WasiqBhamla/boyka-core

IMPORTANT: Make sure to check the Allow edits from maintainers box below this window

@MakodeAjay MakodeAjay requested a review from a team as a code owner June 18, 2022 10:06
@MakodeAjay MakodeAjay requested a review from WasiqB June 18, 2022 10:06
@WasiqB WasiqB changed the title feat(java): ✨ add method to verify header and update docume… feat(java): ✨ add method to verify header and update documentation Jun 18, 2022
@WasiqB WasiqB merged commit 08d5f0b into BoykaFramework:main Jun 18, 2022
@WasiqB WasiqB added 🚀 pr: new feature PR which introduces new features 🐛 pr: bug fix PR which fixes a bug and removed 🚀 pr: new feature PR which introduces new features 🐛 pr: bug fix PR which fixes a bug labels Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 pr: new feature PR which introduces new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: Add assertion method for response headers
2 participants