Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): ✨ add feature for api response json schema validation #92

Merged
merged 15 commits into from
Jun 22, 2022

Conversation

SahilPuri2020
Copy link
Contributor

@SahilPuri2020 SahilPuri2020 commented Jun 20, 2022

Closes: #86

Type of changes?

  • Bug fixes: Non-breaking change which fixes an issue
  • New feature: Non-breaking change which adds a new feature
  • Performance improvement: Non-breaking change which improves performance
  • Documentation: Non-breaking change which improves documentation
  • Other: Non-breaking change which does not fit into the above categories
  • Breaking change: A breaking change which requires a new version of the library

Checklist for Java project

  • Change not related to Java project

Following checklists are optional if above checkbox is selected:

  • Copyright banner comment added to newly added files, except *.md, *.yml, *.json?
  • Proper JavaDoc updated in main and test classes for all public classes and methods?
  • Tests added for changes?
  • Tests are passing locally?
  • Check style checks are passing locally?
  • Test coverage is at least 80% for newly added changes?
  • There are no SonarCloud issues?
  • README updated? (if applicable)
  • Documentation website updated for the PR raised?

Checklist for Website

  • Change not related to Website project

Following is optional if above checkbox is selected:

  • Lint check passes locally?
  • Prettier check passes locally?
  • Build command working fine locally?

Reviewers

@WasiqBhamla/boyka-core

IMPORTANT: Make sure to check the Allow edits from maintainers box below this window

@SahilPuri2020 SahilPuri2020 requested a review from a team as a code owner June 20, 2022 14:46
@SahilPuri2020 SahilPuri2020 requested a review from WasiqB June 20, 2022 14:46
@WasiqB WasiqB changed the title Issue 86 feat(java): ✨ add feature for api response json schema validation Jun 20, 2022
@WasiqB WasiqB merged commit b12e1f8 into BoykaFramework:main Jun 22, 2022
@WasiqB WasiqB added the 🚀 pr: new feature PR which introduces new features label Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 pr: new feature PR which introduces new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ : Add Schema validation assertion for API responses
2 participants