Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

[Feature] Add evolution column to pokemon #9

Open
Mygod opened this issue Aug 30, 2020 · 6 comments
Open

[Feature] Add evolution column to pokemon #9

Mygod opened this issue Aug 30, 2020 · 6 comments

Comments

@Mygod
Copy link
Contributor

Mygod commented Aug 30, 2020

futureproof

@versx
Copy link
Collaborator

versx commented Aug 31, 2020

What do you think the column name should be, evolution_id ?

@Mygod
Copy link
Contributor Author

Mygod commented Aug 31, 2020

I was thinking about evolution but that is also fine.

@Mygod
Copy link
Contributor Author

Mygod commented Aug 31, 2020

Technically gamemaster calls it temporary evolution lol.

@clburlison
Copy link

What's the value of adding this data in the first place? Not criticism either way generally curious

@versx
Copy link
Collaborator

versx commented Aug 31, 2020

I think just for visuals, but they aren't in the wild so probably useless for now.

@Mygod
Copy link
Contributor Author

Mygod commented Aug 31, 2020

I think it is best to just have a data structure equivalent to the PokemonDisplay we have in game. This way we can have a more structured code in both MapJS, DataParser and other projects.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants