Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change /getanswers to filter based on createTime and also fix multiple toggle bug #165

Closed
acao22 opened this issue Jul 18, 2024 · 0 comments · Fixed by #166
Closed

Change /getanswers to filter based on createTime and also fix multiple toggle bug #165

acao22 opened this issue Jul 18, 2024 · 0 comments · Fixed by #166
Assignees
@acao22
Labels
enhancement New feature or request

Comments

@acao22
Copy link
Collaborator

acao22 commented Jul 18, 2024 •
edited
Loading

Change /getanswers and /getagreement to filter based on createTime, not id

Description: this is a fix-up following my other issue #157 when we implemented changing answers. Currently /getanswers and /getagreement are set up to filter based on id, not the creation time. For each statement, we want to only display the user's latest answer for that statement. Since id increments each time a new statement is added, it does currently work, but it's better practice and more accurate to filter based on createTime

Also, found a bug where you can't change both I_agree and others_agree at once; only one of them updates
@acao22 acao22 added the enhancement New feature or request label Jul 18, 2024
@acao22 acao22 self-assigned this Jul 18, 2024
@acao22 acao22 changed the title Change /getanswers to filter based on createTime, not id Change /getanswers to filter based on createTime and also fix multiple toggle bug Jul 19, 2024
@acao22 acao22 mentioned this issue Jul 19, 2024
Merged
@amirrr amirrr linked a pull request Jul 19, 2024 that will close this issue
165 Filter statements by createAt() and also fix toggling multiple answers not updating properly #166
Merged
@JamesPHoughton JamesPHoughton mentioned this issue Jul 22, 2024
Open
@acao22 acao22 mentioned this issue Jul 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acao22 acao22

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@acao22