Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for use of SAM #3

Open
MikeLippincott opened this issue Jan 14, 2024 · 0 comments
Open

Add documentation for use of SAM #3

MikeLippincott opened this issue Jan 14, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@MikeLippincott
Copy link
Member

          Some other comments I have:
  1. In this notebook, you create a directory for the 3.sqlite_output. I do not see this directory in the PR, and I am curious why it is created here and not in the feature extraction folder where you use CellProfiler to output an SQLite file.
  2. In code cell 4, there is commented-out code. I recommend removing this commented-out code if it is not used.
  3. This might be beyond the scope of this PR, but in a README, I would recommend describing SAM and how it works. Are there any parameters you need to set? What are the functions that you use? What is the output?

Originally posted by @jenna-tomkinson in #1 (comment)

@MikeLippincott MikeLippincott added the documentation Improvements or additions to documentation label Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant