Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panel: harmonise icon sizing #269

Open
headbank opened this issue Aug 31, 2024 · 5 comments
Open

panel: harmonise icon sizing #269

headbank opened this issue Aug 31, 2024 · 5 comments

Comments

@headbank
Copy link

Just been making first steps in wayfire and one thing that struck me was how many individual steps are needed to resize the panel consistently. You need to change the icon-size for every plugin that has one (including some that are not mentioned in the wf-shell.ini.example document). Even using wcm this is a chore.

I propose that there be a global setting for icon size, that the individual plugin settings can override if specified.

@ammen99
Copy link
Member

ammen99 commented Sep 1, 2024

This might be possible with CSS, but I am no expert.

cc @trigg ?

@trigg
Copy link
Contributor

trigg commented Sep 1, 2024

Changing Icon size by CSS is possible in GTK4, but not 3.

Edit: Link was less helpful than I hoped. -gtk-icon-size property is the one I meant to point to

@headbank
Copy link
Author

headbank commented Sep 1, 2024

Perhaps I'm misconstruing the intent of the comments above, but they seem to pertain to users being able to hack on CSS files to achieve default size, which gets away from the kind of usability enhancement I had in mind, namely a global default option in wf-shell.ini. (Perhaps you are in fact discussing internals of how to implement it, in which case apologies for the misunderstanding.)

There must already be a coded default size that applies when no *_icon_size value has been set for a plugin in wf-shell.ini. My thought was that this could be exposed as an option under [panel] but that the existing per-plugin values could still override it if specified.

Additional thought: If user does not specify a global default size, maybe it would make some sense for it to be dynamically derived from the minimal_height value?

@ammen99
Copy link
Member

ammen99 commented Sep 1, 2024

Perhaps I'm misconstruing the intent of the comments above, but they seem to pertain to users being able to hack on CSS files to achieve default size, which gets away from the kind of usability enhancement I had in mind, namely a global default option in wf-shell.ini. (Perhaps you are in fact discussing internals of how to implement it, in which case apologies for the misunderstanding.)

There must already be a coded default size that applies when no *_icon_size value has been set for a plugin in wf-shell.ini. My thought was that this could be exposed as an option under [panel] but that the existing per-plugin values could still override it if specified.

Additional thought: If user does not specify a global default size, maybe it would make some sense for it to be dynamically derived from the minimal_height value?

Most of the appearance is already controlled via CSS, including launcher animations in recent wf-panel versions, so I wouldn't say it is a hack. However this is not possible via css unless we move to gtk4, so your suggestion for an option is still valid.

@headbank
Copy link
Author

headbank commented Sep 1, 2024

Sorry, I might be guilty of employing a slightly outdated sense of the word "hack" lol. What I'm getting at is that if you're a brand new user and a non-technical one at that, you'd prefer a common tweak like resizing the panel to be at your fingertips via GUI, in a single action. Keeping UI hackable (again, old sense) for power users and themers is great but it's nice if the rest of us don't need to go to those kinds of lengths for simple refinements.

Perhaps it's a little early in this project's development to be piling up "finesse" tickets like this when there are still bigger fish to fry but as a first-time user it just struck me as potential low-hanging fruit with a good UX payout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants