Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer on mobile is too crowded #215

Open
0xjim opened this issue Sep 15, 2022 · 8 comments
Open

Footer on mobile is too crowded #215

0xjim opened this issue Sep 15, 2022 · 8 comments
Labels
CSS Design ticket

Comments

@0xjim
Copy link
Contributor

0xjim commented Sep 15, 2022

May need to switch to a hamburger menu

Image

@ibkay998
Copy link

Hamburger menu for footer not very common. I could try restructuring it and changing the font size to make it more UI friendly.

@diegoprudencios
Copy link

IMO we should adapt the design depending on the view size.. something like this:

Screenshot 2022-09-26 at 09 19 12

Figma file:
https://www.figma.com/file/wXczUcc9WlLtpuVJmHVYZm/Memixer---Fixes-1?node-id=1797%3A4242

@ibkay998
Copy link

This makes sense when you said hamburger menu what came to mind was click and drop menu. I could use media queries to get this done

@ibkay998
Copy link

made the neccessary changes
Screenshot (287)
Screenshot (289)
Screenshot (288)

@ibkay998
Copy link

I am new to open source i saw that you use bots to automate pull requests mine seems to have failed some of the checks

@diegoprudencios
Copy link

diegoprudencios commented Sep 28, 2022

This looks good.

I have 3 more topics about the footer.

  1. Can we use something like 64px below the footer, to avoid letting it too close to the edge of the view?

Screenshot 2022-09-28 at 11 44 40

  1. Let's use the same padding on the left and right sides. We can use 40px.

Screenshot 2022-09-28 at 11 51 04

  1. Can we use more space between the links? 32px is enough.

@ibkay998
Copy link

Fixed the margin bottom and padding left and padding right
Screenshot (290)

@ibkay998
Copy link

just seeing the third change
Screenshot (293)

@0xjim 0xjim moved this from Backlog to Prioritized in re:meme V1.1 Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Design ticket
Projects
Status: Prioritized
Development

No branches or pull requests

3 participants