Camera View Orientation Bug?

[ghost]

If i change the Orientation on the iPad (iOS 11) its rotating the Camera View.
After its rotated the Axis in the Camera View are swapped. When i turn the iPad to the left the camera view moves the visible camera output to the bottom.
Is this a bug or could u give me any advice to fix this behaviour?
Its mentioned in #76 and #185 and it's still a problem or am i missing something?

[bdjessup]

I am still seeing this bug as well (iPad Pro, iOS 13).

Regardless of whether an app is launched in landscape or portrait, the scanner opens in portrait.

[github-actions]

This issue is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.

[Pellagius]

Just bumping to add interest - Im of firm belief this is actually an issue at the iOS framework level, other libraries and scanning implementations have users reporting the same issue. I first discovered it using WeScan.

I experience the bug on an iPad Air iOS 12.4.8, there are other iOS devices not experiencing the bug.

Is there any insight into its remedy here?

[AvdLee]

Is there any insight into its remedy here?

We have not yet found the time to dive in. In those other projects, have you found an example with a fix too? That could help speed up fixing this.

[ethanwa]

My customers are seeing this bug as well on all iPad devices. Any way to make this a priority fix?

[AvdLee]

@ethanwa unfortunately, we're not actively developing WeScan at this moment. We're happy to receive any contributions and review accordingly.

[willm132]

Has anyone been able to fix this yet? My app only works in landscape and the camera pops up in portrait orientation.

[willm132]

@AvdLee Would just changing this be able to fix our issues?

override public var supportedInterfaceOrientations: UIInterfaceOrientationMask {        
    return .portrait   
// can we change this to .landscape to change the orientation? 
// Or is there more to this like having to change camera properties?
}

[AvdLee]

@AvdLee Would just changing this be able to fix our issues?

I've not tried that out but to me, that would disable landscape completely, wouldn't it?

[willm132]

@AvdLee I am not sure. Is anyone able to take a look at a fix for this?

[AvdLee]

@AvdLee I am not sure. Is anyone able to take a look at a fix for this?

Currently, WeScan is not on our list of priorities. We're open for contributions and aim to review PRs within 1 working day. So feel free to apply a fix 🙂

[samkass]

I also ran into this.

So I tried to dig into it, and it's a bit of a rabbit hole. Just returning .all from supportedInterfaceOrientations doesn't do much. I then was able to correct the video preview in CameraScannerViewController by updating the orientation in viewDidLayoutSubviews, which fixed the video, but the rectangle overlays were still wrong. To fix that you'd have to recalculate the quad transforms. Once the preview is fixed, you'd then have to update the capture code to ensure the actual images are properly processed in the right orientation.

The whole package seems to be designed for portrait mode, so there is no isolated surgical fix.

I looked around for other example code, and all examples I could find, including from Apple, do not handle landscape mode properly for any of their VN examples with previews.

The last comment here was from 2 years ago, so if anyone else solved this in the interim I'm interested in what they did.

[pragadeeshNIS]

Hi, Any update on this issue?
Did anyone find any solution for this?

[camilocalvo]

I got this to work, but improvements to the code are welcome.

First, at the top of the CameraScannerViewController.swift file, add a variable to track the current orientation:

private var orientation: UIDeviceOrientation = .portrait

Next, you'll need to listen for orientation changes and use those to rotate the video feed manually. You can use the following modification to viewDidLayoutSubviews, plus a helper function:

private func updatePreviewLayer(layer: AVCaptureConnection, orientation: AVCaptureVideoOrientation) {
    layer.videoOrientation = orientation
    videoPreviewLayer.frame = view.bounds
}

override public func viewDidLayoutSubviews() {
    super.viewDidLayoutSubviews()
    
    if let connection = videoPreviewLayer.connection {
        let currentDevice = UIDevice.current
        orientation = currentDevice.orientation
        
        let previewLayerConnection: AVCaptureConnection = connection
        
        if previewLayerConnection.isVideoOrientationSupported {
            switch orientation {
            case .portrait: self.updatePreviewLayer(layer: previewLayerConnection, orientation: .portrait)
            case .landscapeRight: self.updatePreviewLayer(layer: previewLayerConnection, orientation: .landscapeLeft)
            case .landscapeLeft: self.updatePreviewLayer(layer: previewLayerConnection, orientation: .landscapeRight)
            case .portraitUpsideDown: self.updatePreviewLayer(layer: previewLayerConnection, orientation: .portraitUpsideDown)
            default: self.updatePreviewLayer(layer: previewLayerConnection, orientation: .portrait)
            }
        }
    }
    
    videoPreviewLayer.frame = view.layer.bounds
}

Now we'll deal with the quad layer, which is also out of sync. Go to the function on line 182, captureSessionManager (there are several functions with that name, so make sure you have the right one). Here, replace the line that sets portraitImageSize with the following two lines:

let rotationAngle = orientation == .portrait ? CGFloat.pi / 2.0 : orientation == .landscapeLeft ? 0 : CGFloat.pi
let portraitImageSize = orientation == .portrait ? CGSize(width: imageSize.height, height: imageSize.width) : CGSize(width: imageSize.width, height: imageSize.height)

And update the rotationTransform assignment later in the function to use your new rotationAngle variable:

let rotationTransform = CGAffineTransform(rotationAngle: rotationAngle)

Finally, there's ensuring that the image is oriented correctly when you go to edit it. For this, go to the completeImageCapture function at the end of the CaptureSessionManager extension (line 324). The changes here are spread out around the function, so I'll post the entire modified function. The idea is to rotate the image and the quad layer by the proper amount for both landscape orientations.

private func completeImageCapture(with imageData: Data) {
        DispatchQueue.global(qos: .background).async { [weak self] in
            CaptureSession.current.isEditing = true
            guard let image = UIImage(data: imageData) else {
                let error = ImageScannerControllerError.capture
                DispatchQueue.main.async {
                    guard let self else {
                        return
                    }
                    self.delegate?.captureSessionManager(self, didFailWithError: error)
                }
                return
            }
            
            let currentDevice = UIDevice.current
            let orientation = currentDevice.orientation
            
            var rotatedImage = image
            var angle: CGFloat = CGFloat.pi / 2

            switch orientation {
            case .landscapeLeft:
                rotatedImage = UIImage(cgImage: image.cgImage!, scale: 1.0, orientation: .down)
                angle = 0
            case .landscapeRight:
                rotatedImage = UIImage(cgImage: image.cgImage!, scale: 1.0, orientation: .up)
                angle = CGFloat.pi
            default:
                break
            }

            var quad: Quadrilateral?
            if let displayedRectangleResult = self?.displayedRectangleResult {
                quad = self?.displayRectangleResult(rectangleResult: displayedRectangleResult)
                quad = quad?.scale(displayedRectangleResult.imageSize, rotatedImage.size, withRotationAngle: angle)
            }

            DispatchQueue.main.async {
                guard let self else {
                    return
                }
                self.delegate?.captureSessionManager(self, didCapturePicture: rotatedImage, withQuad: quad)
            }
        }
    }

Let me know if anyone has any questions. If demand is high enough I can create a PR as well.