You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
emptyrivers opened this issue
Jun 10, 2024
· 2 comments
Labels
🎨 Feature RequestThis is a request for a new feature, or an expansion of an existing feature.🏃 Performance IssueThis issue concerns the performance impact of WeakAuras.
While making this little thing I had the opprotunity to work with the 'modern' scroll templates, and I think they could be put to good use in WeakAuras, too. Here is a tutorial on how to make use of them.
In particular, I think we should modify this part of Options to make use of WowScrollBox + LinearizedTreeDataProvider:
We currently use Ace widgets, and are "forced" (are we actually?) to build potentially thousands of them the moment the user opens WeakAurasOptions. This takes a pretty long time if you have a lot of auras, and personally is a big barrier to ever opening options. I predict that using the WowScrollBox system would be the quickest way to eliminate this pain point.
As far as I can tell, WowScrollBox has made its way into every flavor of classic that we support as well, so no need to worry about compatibility problems.
Scrollboxes made using a combination of WowScrollBox + ScrollUtil work differently in important ways:
ScrollUtil makes heavy use of object pools to minimize total # of frames used. In particular this means that only what actually needs to be displayed in the scroll view is "created".
instead of maintaining a sorted list of frames at all times, ScrollUtil instead makes use of a data provider which can be provided a sort comparator (not unlike how dynamic group sorting works, though blizzard doesn't bother with the incremental sorting that we do)
The text was updated successfully, but these errors were encountered:
Also note the WeakAurasScrollArea widget for texture picker that is more clever than the original AceGUIContainer-ScrollFrame widget as it doesn't create all not visible elements
🎨 Feature RequestThis is a request for a new feature, or an expansion of an existing feature.🏃 Performance IssueThis issue concerns the performance impact of WeakAuras.
(mostly a note for myself)
While making this little thing I had the opprotunity to work with the 'modern' scroll templates, and I think they could be put to good use in WeakAuras, too. Here is a tutorial on how to make use of them.
In particular, I think we should modify this part of Options to make use of WowScrollBox + LinearizedTreeDataProvider:
We currently use Ace widgets, and are "forced" (are we actually?) to build potentially thousands of them the moment the user opens WeakAurasOptions. This takes a pretty long time if you have a lot of auras, and personally is a big barrier to ever opening options. I predict that using the WowScrollBox system would be the quickest way to eliminate this pain point.
As far as I can tell, WowScrollBox has made its way into every flavor of classic that we support as well, so no need to worry about compatibility problems.
Scrollboxes made using a combination of WowScrollBox + ScrollUtil work differently in important ways:
The text was updated successfully, but these errors were encountered: