fix(api): ensure loaders.js returns a body if not required. fixes #47

Author: shakyShane

rjs-parse/src/build_config.rs

@@ -297,7 +297,12 @@ impl RequireJsBuildConfig {
                 )
             })
             .collect();
-        items.join("\n")
+
+        if items.len() > 0 {
+            items.join("\n")
+        } else {
+            include_str!("./js/no-loaders.js").to_string()
+        }
     }
     ///
     /// Walk the mixins fields and flatten to a simple Vec<String>

rjs-parse/src/js/no-loaders.js

@@ -0,0 +1,9 @@
+/*
+ *
+ * You haven't configured any modules yet, so you don't
+ * need this 'loaders.js' file.
+ *
+ * Once you configure some additional bundles this file
+ * will be populated with some Javascript :)
+ *
+ */

tests/api.rs

@@ -41,13 +41,19 @@ fn test_config_json() {
 
 #[test]
 fn test_loaders_js() {
-    api_get(DEFAULT_ARGS.to_vec(), "/__bs/loaders.js", |result| {
-        let (_sys, _url, res) = result.expect("api returned");
+    let args = &[
+        "config-gen",
+        "http://example.com",
+    ];
+    api_get(args.to_vec(), "/__bs/loaders.js", |result| {
+        let (_sys, _url, mut res) = result.expect("api returned");
+        let t = &res.text().expect("unwrap text response");
         let ct = &res
             .headers()
             .get(http::header::CONTENT_TYPE)
             .expect("has content-type");
         assert_eq!(ct.to_str().expect("header->str"), "application/javascript");
+        assert!(t.len() > 0);
     });
 }