Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MsgPack: Overflow Assertions #150

Closed
dOrgJelli opened this issue Feb 10, 2021 · 0 comments · Fixed by #211 or #230
Closed

MsgPack: Overflow Assertions #150

dOrgJelli opened this issue Feb 10, 2021 · 0 comments · Fixed by #211 or #230
Assignees
@krisbitney
Labels
pri: high

Comments

@dOrgJelli
Copy link
Contributor

Assert error messages whenever an overflow is encountered. Currently, for example, if you pass in the value 569 for an argument of type UInt8 the resulting deserialized value will be 57. 569 - (256 * 2) = 57.

We should instead throw an error saying that the value given is not within the valid range.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krisbitney krisbitney

Labels
pri: high
Projects
None yet
Milestone
No milestone
3 participants
@morrigan @dOrgJelli @krisbitney