Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should imports also have an internal name? #593

Closed
ghost opened this issue Mar 8, 2016 · 3 comments
Closed

Should imports also have an internal name? #593

ghost opened this issue Mar 8, 2016 · 3 comments
Milestone

Comments

@ghost
Copy link

ghost commented Mar 8, 2016

Imports have not been named when adding the names section which assigns names for function indexes but imports are not in the same index space.

A view-source formatter could use the import function name to create a usable internal name, but the same could be said for exports, and might it have been an oversight to not name the imports?

@ghost
Copy link
Author

ghost commented Mar 12, 2016

A suggestion here #596

@jfbastien jfbastien added this to the MVP milestone Apr 5, 2016
@ghost
Copy link
Author

ghost commented Jul 12, 2016

Is this still an issue or have the design changes made this obsolete or addressed this?

@lukewagner
Copy link
Member

Since the names section assigns names to function indices and #682 puts function imports into the function index space, then this issue is addressed.

@ghost ghost closed this as completed Jul 12, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants