Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External name for memory export? #607

Closed
ghost opened this issue Mar 13, 2016 · 6 comments
Closed

External name for memory export? #607

ghost opened this issue Mar 13, 2016 · 6 comments
Milestone

Comments

@ghost
Copy link

ghost commented Mar 13, 2016

The current binary encoding has a byte flag for memory export, and v8 seems to interpret this an export named "memory". The spec seems to support other names, and even multiple exports of the memory with different names. Looks like an issue to be resolved.

@Teemperor
Copy link
Member

The original pull request 243 also had a discussion about that.

@ghost
Copy link
Author

ghost commented Mar 30, 2016

@Teemperor The link might not be correct? Could you summarize the reason why the spec and encoding seem to differ here?

@Teemperor
Copy link
Member

@JSStats Fixed the link, thx!

@ghost
Copy link
Author

ghost commented Mar 31, 2016

@Teemperor Thank you but I still don't see an answer there? In fact that PR includes the follow test which not only names the memory something other than "memory" but has multiple names for it. The binary encoding has only a single bit to flag the memory as being exported and can not represent these names?

(module (memory 0 0) (export "a" memory) (export "b" memory))

@Teemperor
Copy link
Member

Yeah, I just wanted reference the related discussion about "why multiple memory exports" :)

@jfbastien jfbastien added this to the MVP milestone Apr 5, 2016
@sunfishcode
Copy link
Member

As of #682, memory exports do have an external name. However, BinaryFormat.md is not yet updated to reflect this.

@ghost ghost closed this as completed Jul 12, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants