Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement event->tag renaming in core tests #169

Closed
takikawa opened this issue Jun 30, 2021 · 2 comments
Closed

Implement event->tag renaming in core tests #169

takikawa opened this issue Jun 30, 2021 · 2 comments

Comments

@takikawa
Copy link
Collaborator

takikawa commented Jun 30, 2021 •
edited
Loading

The recently merged core tests in #160 still use the event terminology, so they need to be renamed to tag for compatibility with issue #159. This was already brought up in the discussion thread in #160, but I'm filing this issue so it's tracked somewhere (it'd be useful for importing the spec tests for tooling/browser test suites).

Is someone working on this change already? (@thibaudmichaud maybe?) If not I could work on a PR.
@thibaudmichaud
Copy link
Collaborator

I haven't started working on this change yet, you can take it. Thanks!

@takikawa takikawa mentioned this issue Jul 1, 2021
Merged
@takikawa
Copy link
Collaborator Author

takikawa commented Jul 6, 2021

Fixed by #170.

@takikawa takikawa closed this as completed Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@takikawa @thibaudmichaud