-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build.py doesn't build tests in subdirectories #1687
Comments
This can be worked around by updating |
Building these required hacking up the build.py script: https://github.com/WebAssembly/gc/issues/450
I think I touched it just to tweak error reporting. We don't use this script anymore though and have a custom way we run the spec tests in SM. |
We are also not using this script in V8. The script should be easy to fix, though, and I think there is value in having this script. I put it on my TODO list to fix it eventually. |
The tests in https://github.com/WebAssembly/gc/tree/main/test/core/gc aren't build by the
build.py
, which only looks for *.wast files in test/core/:https://github.com/WebAssembly/gc/blob/ec57b2a506a7e220a1cdb980adc7fdcca8b31d05/test/build.py#L70
Are these tests not being run yet, or should they be moved to the parent directory when they are complete?
The text was updated successfully, but these errors were encountered: