Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Name" section should allow names for globals/tables/memories #736

Closed
NWilson opened this issue Mar 1, 2018 · 3 comments
Closed

"Name" section should allow names for globals/tables/memories #736

NWilson opened this issue Mar 1, 2018 · 3 comments

Comments

@NWilson
Copy link

NWilson commented Mar 1, 2018

Currently, the names section only allows naming the module, functions, and locals.

It should allow for naming globals, or debuggers won't be able to attach friendly names to the globals being accessed.

I suppose tables and memories should probably allow naming as well, although it's less likely in practice that there'll be more than one of those.

@AndrewScheidecker
Copy link
Contributor

I have a pending pull request that supports round-tripping all the names in the text format through the names section: WebAssembly/design#1064

@NWilson
Copy link
Author

NWilson commented Mar 1, 2018

Aha, thanks! I was looking in the wrong repo there. (In fact, I'm a bit confused, since the "name" section is documented in this repo too - so I don't know where issues should be raised... oh well!)

@rossberg
Copy link
Member

rossberg commented May 3, 2018

Closing this, given its a feature request and there is WebAssembly/design#1064.

@rossberg rossberg closed this as completed May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants