Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names for globals from name section are not used in wasm2wat #1584

Closed
sbc100 opened this issue Dec 4, 2020 · 3 comments
Closed

Names for globals from name section are not used in wasm2wat #1584

sbc100 opened this issue Dec 4, 2020 · 3 comments

Comments

@sbc100
Copy link
Member

sbc100 commented Dec 4, 2020

They seem to be ignored:

  (global (;15;) i32 (i32.const 172))
  (global (;16;) i32 (i32.const 168))
  (global (;17;) i32 (i32.const 2904))
  (global (;18;) i32 (i32.const 3644))
@7ombie
Copy link

7ombie commented Jun 29, 2021

It looks like WABT only implemented the standardized part of the Custom Name Section spec, which only supports module names, and identifiers for functions and locals (subsections 0, 1 and 2).

The Extended Name Section Proposal add support for every identifier possible in WAT source (adding subsections 3 through 9).

Can we convert this issue into a feature request?

@sbc100
Copy link
Member Author

sbc100 commented Jun 29, 2021

I think this was added in #1573 and #1659. So I guess we can close this?

@sbc100
Copy link
Member Author

sbc100 commented Jun 29, 2021

Confirmed this was fixed in #1659. Sorry I should have closed this already.

@sbc100 sbc100 closed this as completed Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants