Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate the use of __heap_base #212

Closed
mikevoronov opened this issue Aug 3, 2020 · 4 comments · Fixed by #215
Closed

Activate the use of __heap_base #212

mikevoronov opened this issue Aug 3, 2020 · 4 comments · Fixed by #215

Comments

@mikevoronov
Copy link
Contributor

Seems that https://bugs.llvm.org/show_bug.cgi?id=43613 fixed, what about activating __heap_base disabled by #132 ?
@sbc100
Copy link
Member

sbc100 commented Aug 3, 2020

I suppose it depends on what level of compatibility we want in clang. At the very least we could perhaps use a clang version check here?

@sbc100
Copy link
Member

sbc100 commented Aug 3, 2020

Oh I guess this made it into llvm 9, and I don't think we need to continue to support llvm 8 now that 10 is stable, so I guess you are correct and we should re-enable it.

@mikevoronov
Copy link
Contributor Author

I can resurrect the old PR with __heap_base.

@sunfishcode
Copy link
Member

I agree; I think it's fine to drop support for LLVM 8 for building WASI libc.

@sunfishcode sunfishcode mentioned this issue Aug 4, 2020
Merged
@mikevoronov mikevoronov mentioned this issue Aug 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Activate the use of __heap_base mikevoronov/wasi-libc
3 participants
@sbc100 @sunfishcode @mikevoronov