Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release process should be documented #284

Closed
yamt opened this issue Jan 10, 2023 · 9 comments
Closed

Release process should be documented #284

yamt opened this issue Jan 10, 2023 · 9 comments

Comments

@yamt
Copy link
Contributor

yamt commented Jan 10, 2023

or even automated.

at least it should be clear where release asserts came from.

cf. WebAssembly/wasi-libc#326 (comment)

@sunfishcode
Copy link
Member

I fully agree. The process I inherited is:

  • git tag -a to create an annotated tag
  • git push --tags
  • create a release in the github UI using the new tag
  • manually download the artifacts from the latest CI build
  • rename the windows binaries to names like wasi-sdk-17.0-mingw.tar.gz
  • manually upload the artifacts to the release
  • tag the wasi-libc with wasi-sdk-*

It'd be great to automate this. I myself am not very familiar with the parts of github needed to do this, so any help anyone can offer would be appreciated.

@thewtex
Copy link
Contributor

thewtex commented Jan 10, 2023

Heads up, the assets are currently missing from wasi-sdk-18: https://github.com/WebAssembly/wasi-sdk/releases/tag/wasi-sdk-18

@sunfishcode
Copy link
Member

That's because I haven't done the manual steps yet :-}. Also, there's a regression being discussed in WebAssembly/wasi-libc#377, which only affects users using -Wl,--initial-memory, and there's a possibility we may do another release soon to fix it.

@yamt
Copy link
Contributor Author

yamt commented Jan 11, 2023

manually download the artifacts from the latest CI build

@TerrorJack suggested to use linux artifacts from docker job: #273 (comment)
is it what you do?

@sunfishcode
Copy link
Member

I download the artifacts from a CI run, such as here: https://github.com/WebAssembly/wasi-sdk/actions/runs/3889687857#artifacts

@yamt
Copy link
Contributor Author

yamt commented Jan 11, 2023

I download the artifacts from a CI run, such as here: https://github.com/WebAssembly/wasi-sdk/actions/runs/3889687857#artifacts

do you mean to include binary from both of dist-ubuntu-bionic and dist-ubuntu-latest?

@sunfishcode
Copy link
Member

I look at the artifacts from the previous release and try to upload the same artifacts.

@TerrorJack
Copy link
Contributor

@sunfishcode It seems the dist-ubuntu-latest artifact has been the choice of the linux binary release for the past few releases. It may also be good to also upload dist-ubuntu-bionic and name it something like wasi-sdk-19.0-ubuntu-bionic.tar.gz, and mention it in the release notes, so when people want to use it in a distro with outdated glibc, they can choose it.

@abrown
Copy link
Collaborator

abrown commented Mar 13, 2023

#295 closes this issue. For those of you that are interested in artifacts using older versions of glibc, let's continue the conversation over in #303. (I see now there are at least three people who want bionic-based artifacts so surely someone can figure out how to do that in the release scripts of #295; perhaps even downgrading the GitHub workflow file to use bionic?).

@abrown abrown closed this as completed Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants