-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use clang-format to format API code #80
Comments
Yeah, I understand the suggestion, but I'm sorry to say that my prior exposure has elicited an allergy to clang-format. Symptoms are cringing pain and curling toe nails when exposed to algorithmic stupor steam-rolling over aesthetics. :) Is the amount of code contributions to expect for this repo large enough that formatting would likely be a problem? |
I understand your feeling, and after using clang-format for a while on WAVM, am still disappointed with the way it formats certain things. But it's also liberating to accept the automatic formatting and focus on more important issues.
I don't know, but this repo will need to continue to evolve with WebAssembly. |
Big +1 to this.
For me this is the only thing that matters; making collaboration easier is much more important than any one person's sense of aesthetics. Obviously, whether formatting is a "problem" could also be subjective; but the cost is small, and adding formatting early is easier than doing it later (e.g. in response to disagreement) when there's a lot of existing code. |
Could you upload a PR with the changes that result for formatting with |
This would make it much easier for collaborators to ensure their changes have formatting that is consistent with the rest of the repo.
I'm locally using a
.clang-format
that just containsBasedOnStyle: Chromium
, which is reasonably close to the existing code, but not perfect. Ideally @rossberg could add a.clang-format
based on his preferences, and apply it to the existing code.The text was updated successfully, but these errors were encountered: