Skip to content
This repository was archived by the owner on Aug 22, 2022. It is now read-only.

Commit 58e343a

Browse files
authored
Avoid libtinfo specifically on linux, where we are seeing issues (#541)
As not having it removes colors on some systems. Oddly on one machine I didn't see this, but testing on another, I do - all the colors are gone. The eventual solution may be to statically link libtinfo. Meanwhile with it we get errors on some linuxes but proper colors, and without it we avoid linux errors but have no colors. With this PR at least the loss of colors is just on linux. See emscripten-core/emsdk#252 #539 #540
1 parent ee1cb39 commit 58e343a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/build.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -809,7 +809,7 @@ def LLVM():
809809
'-DLLVM_ENABLE_PROJECTS=lld;clang',
810810
# linking libtinfo dynamically causes problems on some linuxes,
811811
# https://github.com/emscripten-core/emsdk/issues/252
812-
'-DLLVM_ENABLE_TERMINFO=0',
812+
'-DLLVM_ENABLE_TERMINFO=%d' % (not IsLinux()),
813813
])
814814

815815
jobs = host_toolchains.NinjaJobs()
@@ -961,7 +961,7 @@ def Fastcomp():
961961
'-DLLVM_ENABLE_ASSERTIONS=ON',
962962
# linking libtinfo dynamically causes problems on some linuxes,
963963
# https://github.com/emscripten-core/emsdk/issues/252
964-
'-DLLVM_ENABLE_TERMINFO=0',
964+
'-DLLVM_ENABLE_TERMINFO=%d' % (not IsLinux()),
965965
('-DLLVM_EXTERNAL_CLANG_SOURCE_DIR=%s' %
966966
GetSrcDir('emscripten-fastcomp-clang'))
967967
])

0 commit comments

Comments
 (0)