Skip to content

Problem & fix for subsequent lines overwriting previous... #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AzzaAzza69 opened this issue Mar 22, 2023 · 2 comments
Closed

Problem & fix for subsequent lines overwriting previous... #27

AzzaAzza69 opened this issue Mar 22, 2023 · 2 comments
Assignees

Comments

@AzzaAzza69
Copy link

You can see this happen to the "p" on your animated gif here:
https://i0.wp.com/css-tricks.com/wp-content/uploads/2021/06/syntax-highlighted-textarea.gif
and also if you try this example:

<span></span>
<test>   <-- this line overwrites the bottom of the p in "span" of the above line...

where by the descender part of the "p" is overwritten by the next line...

Proposed fix:
as the lineheight is set to 1.5 via:
code[class*="language-"], pre[class*="language-"] {
it should be also set to 1.5 on (and not 20pt) here:
#editing, #highlighting, #highlighting * {

@WebCoder49
Copy link
Owner

Thank you for this.
I am afraid that I am unlikely to be able to address it until Monday 27/03 as I am very busy at the moment.

@WebCoder49
Copy link
Owner

I am sorry that I couldn't address this for a while as I was busier as I had anticipated. I have now fixed this bug in both the CodePen and the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants