Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/UI rebuild 118 #144

Merged
merged 9 commits into from
Jul 8, 2024
Merged

Features/UI rebuild 118 #144

merged 9 commits into from
Jul 8, 2024

Conversation

jeremy-liss
Copy link

Add and remove groups to a target with a modal

@jeremy-liss jeremy-liss requested a review from obrienben June 25, 2024 04:08
@leefrank9527
Copy link
Contributor

leefrank9527 commented Jul 1, 2024 •
edited
Loading

  1. Have updated the PR to fix:
  • The chips for selected groups can be removed with the right neighbour together.
  • Fix the height of rows on the Group selection table.
  • Repalaced the favicon.ico image.
  • Moved the addGroup method to useTargetGropusDTO. So both the addGroup and removeGroup are processed in a single instance.
  1. Some other advices:
  • For TargetAddGroupsModal, a Popover component can be taken as an option as well.
  • The Search function on TargetAddGroupsModal is better to support wildcard match.
  • It's better to fix the height of the Table on TargetAddGroupsModal.

@leefrank9527 leefrank9527 self-requested a review July 1, 2024 08:31
@jeremy-liss jeremy-liss linked an issue Jul 2, 2024 that may be closed by this pull request
Target Screen - Groups + Add New Group #118
Open
@leefrank9527
Copy link
Contributor

leefrank9527 commented Jul 4, 2024 •
edited
Loading

It looks good for me now. It can be mergerd.

@jeremy-liss jeremy-liss merged commit fd07170 into features/ui-rebuild Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obrienben obrienben Awaiting requested review from obrienben

@leefrank9527 leefrank9527 Awaiting requested review from leefrank9527

Assignees

@obrienben obrienben

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Target Screen - Groups + Add New Group
3 participants
@jeremy-liss @leefrank9527 @obrienben