Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/UI rebuild 114 #140

Merged
merged 19 commits into from
Jun 18, 2024
Merged

Conversation

jeremy-liss
Copy link

  • Builds out the Profile, Description and Access tabs of the Target page.
  • Moves Groups and Seeds into General tab
  • Adds delete target functionality with confirm dialog
  • Adds Types for Target parts

@leefrank9527
Copy link
Contributor

  1. With the md-light-indigo theme, the height of input fields are stretched. It dwafted the buttons and checkboxes. I would like to unify the height of form fields in TargetList.
  2. Some compling errors:
  • src/stores/target.ts:286:53
 error TS2339: Property 'split' does not exist on type 'string | number | boolean'.
  Property 'split' does not exist on type 'number'.

286                     override.value = override.value.split(',');

It can be fixed by coverting to string explicitly.

  • src/views/target/target-tabs/TargetTabPanelAccess.vue
    error TS2322: Type '{ preventAbort?: boolean | undefined; preventCancel?: boolean | undefined; preventClose?: boolean | undefined; signal?: { readonly aborted: boolean; onabort: ((this: AbortSignal, ev: Event) => any) | null; ... 4 more ...; dispatchEvent: (event: Event) => boolean; } | undefined; }' is not assignable to type 'Nullable<string>'.
    In fact, it's the StreamPipeOptions in types/target.ts which caused this issue.
  1. When close the TargetTab View, the TargetList View will be refreshed. That would be good if the the Target List can stay at the previous status when cancel to close the TargetTab View, and only refresh the data in the table when save to close the TargetTab view.
  2. The input form in General and Access tabs layout 2 columns, the one in Description and Profile tabs layout 1 column. My options is to unify to 1 column and set the input to full width. The height of the fields are different, it's hard to align every fields with multiple columns.

@jeremy-liss jeremy-liss merged commit 0f80a8b into features/ui-rebuild Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Target Screen - Access Target Screen - Description Target Screen - Profile
2 participants