Add helper function to update an option #110
Conversation
mAAdhaTTah
force-pushed
the
option-update-helper
branch
from
24e1654
to
b9bf698
Compare
|
Looks like a good addition. Care to attempt a unit test to accompany this new function and complement the existing test? |
|
Will do that when I get home. You prefer a squashed commit or two commits? Edit: Nevermind, I broke up the one unit test into 3, as you're testing 3 different functions. Hope that's ok! |
mAAdhaTTah
force-pushed
the
option-update-helper
branch
from
b9bf698
to
1a6ea05
Compare
| */ | ||
| function cmb2_update_option( $option_key, $field_id, $value, $resave = false, $single = true ) { | ||
| if ( cmb2_options( $option_key )->update( $field_id, $value, $resave, $single ) ) { | ||
| return cmb2_options( $option_key )->set(); |
There was a problem hiding this comment.
since you are using the set method, there is no reason to take in the $resave argument to this helper function (because using set, it will save it to the DB). I would remove it from the cmb2_update_option function and set it to 'false' for cmb2_options()->update.
|
I updated the function to remove |
|
No prob, happy to help. |
Working on WP-CLI functionality for a plugin; would be helpful to use this to update options outside of the displayed form.