Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Update navigation #844

Closed
dovecode opened this issue Jun 19, 2020 · 2 comments
Closed

Suggestion: Update navigation #844

dovecode opened this issue Jun 19, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@dovecode
Copy link

The navigation in Webgoat is quite ... odd

The main issue is with the "tabs" in a given ... "lesson"? They are tiny and the color-coding is unintuitive and downright hostile to people with color vision impairments.

For the tabs, I would suggest an actual tabbed interface. This would allow for naming the ... "exercises"? "tasks"? and also make it clear when an exercise is just that, as opposed to the lesson-type exercises? tasks? lessons? (I'm sorry, but I don't really get the nomenclature here).

The whole flashing-the-current-task is just disturbing. There's a reason they removed the <blink> tag.

I would also suggest getting rid of the collapsing left-nav. There aren't really that many options there. They'd all fit in most modern monitors as an expanded list. Also, most groups have just 1-2 lessons anyway.

@nbaars
Copy link
Collaborator

nbaars commented Oct 22, 2020

Solved the blinking part and the hide menu button is gone now, see #884

@nbaars
Copy link
Collaborator

nbaars commented Nov 8, 2020

With: #890 it also solves:

  • Underline link is now gone (a href was underlining the icons)
  • Outline the buttons
  • Improve size of buttons
  • Removed shading when page is selected and replaced it with a complete border around the icon

@nbaars nbaars added this to the 8.1.1 milestone Nov 8, 2020
@nbaars nbaars self-assigned this Nov 8, 2020
@nbaars nbaars added 3 - Review waiting for release Issue is fix, waiting on new release and removed 0 - Backlog labels Nov 8, 2020
@nbaars nbaars added 4 - Done and removed 3 - Review waiting for release Issue is fix, waiting on new release labels Jul 27, 2021
@nbaars nbaars closed this as completed Jul 27, 2021
@nbaars nbaars modified the milestones: 8.1.1, 8.2.0 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants