-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KERIA logs should indicate the agent that the log applies to #324
Comments
It would be useful if the log format was standardized throughout as well. Maybe to take inspiration from https://en.wikipedia.org/wiki/Common_Log_Format. If we add the controller id and/or agent id, and then log every request, it would be much easier to track down certain errors. |
From our dev meeting, the keri logging has advanced log features to add additional fields, for instance different formatters. There might be some witness examples with formatters. |
From Sam during the meeting: |
From our vLEI-dev-community call: |
At HP for both security and privacy reasons we had to scrub logs of all identifiers like usernames. So while its helpful for debugging including full identifiers might result in a lot of work down the road. You might consider truncating the identifiers, to something like first 4 and last 4 characters. |
@SmithSamuelM yes, I truncated the identifiers to the first 8 characters, though using the first 4 and last 4 would be even better. I will change my logging PRs to reflect this. |
Feature request description/rationale
Currently there is no distinction between logs per agent. Prefix the logs with the agent id.
The text was updated successfully, but these errors were encountered: