Custom replacer context

[panta82]

Hey, I'm using a custom replacer when stringifying objects such as dates and errors. After switching to circular-json, I noticed that my custom replacers weren't doing their job.

It seems the problem is here:

if (replacer) value = replacer(key, value);

This doesn't pass the usual context for JSON.stringify - instead of the object being stringified, 'this' references the global JSON object. Since I was doing something like:

if (this[key] instanceof Date) { /*do my custom toString() */ }

... my special converters weren't being called (a nasty silent fail). Suggested solution:

if (replacer) value = replacer.call(this, key, value);

[WebReflection]

you are right. It should be fixed now with tests included. Please check/test and close this ticket if it works as you expect. Thank you.

[WebReflection]

P.S. … in your very specific example, you don't need to check this[key] just value so …

if (value instanceof Date) return 'your thing';

That said, shared Dates objects across properties can be better packed via CircularJSON plus Date by default serialize into unserializable strings so eventually the problem would be in the parse() method (and I gonna check that too)

[WebReflection]

done, both fixe with the right context.

[panta82]

No, the provided value is already converted by the default stringifier. In this particular case, instead of date object, I'm getting string (in the format eg: "2013-10-01T16:15:58.181Z").

Anyway, already fixed my local version and tested. Seems to be working ok. Closed.

[WebReflection]

The reviver had same issue. Grab the latest and you should be ok