Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantity translation thereshold #3436

Open
OscarBeiro opened this issue Jan 28, 2020 · 6 comments
Open

Quantity translation thereshold #3436

OscarBeiro opened this issue Jan 28, 2020 · 6 comments
Labels
enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship.

Comments

@OscarBeiro
Copy link

OscarBeiro commented Jan 28, 2020

Is your feature request related to a problem? Please describe.
We are developing an Android App, and we are thrilled with our recent Weblate integration to manage translations, however, when a new translation language is started, and the percentage of strings translated is low, the app doesn't look right.

Describe the solution you'd like
A threshold that could be configured in order to meet a minimum percentage of translation before it was pushed from Weblate GIT to VCS repository. It could be per Project or per Component.

For instance, if we set minimum valid translation to 60%, no language files with less than 60% of strings translated will be pushed to our repository.

Maybe .gitignore could be used to add those files until they meet the required translation limit.

Thanks

@nijel
Copy link
Member

nijel commented Jan 28, 2020

The current approach by Weblate is that everything gets committed to Git. This way people working on Git have same view as Weblate it works without any problems to work on the translations in both Weblate and Git. Delaying committing some files would break this assumption. Another reason is that this reduces vendor lock-in - the translations main source is the Git repository, not Weblate.

I bet there is way to filter available languages in Android as that's what I'd expect from most apps...

@nijel nijel added enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship. labels Jan 28, 2020
@github-actions
Copy link

This issue has been put aside. Currently, it is unclear whether it will be ever implemented as it seems to cover too narrow use case or doesn't seem to fit into Weblate. Please try to clarify the use case or consider proposing something more generic to make it useful to more users.

@grote
Copy link

grote commented Jun 7, 2023

This is also an issue for the F-Droid client app. We currently have a complex process with lengthy python scripts to exclude incomplete translations which is very painful.

I get the part about everything being in git. However, maybe there's a way that for example when making merge/pull requests those are made from a branch that only includes the complete translations.

@papjul
Copy link

papjul commented Aug 10, 2023

I bet there is way to filter available languages in Android as that's what I'd expect from most apps...

As far as I know, Android will look into translation directories to find a matching translation. I can exclude the translation from showing up in the "Set language manually" preference, however that won't prevent users which have this language as their main Android language to use it.

Maybe .gitignore could be used to add those files until they meet the required translation limit.

I get the part about everything being in git. However, maybe there's a way that for example when making merge/pull requests those are made from a branch that only includes the complete translations.

Could one of these solutions fit? Or maybe add a way to commit incomplete translations to a separate directory on Git such as .weblate/ if a different branch is not appropriate?

At least, not making a commit if there is nothing in it could be a good start? Some people add new languages but they don't translate anything :/

In another discussion, I explained how I would see this feature with a special case for existing translations below threshold:

  • I define a % to reach for a language to be valid, for example 30%
  • When a user add a new language on Weblate, it will only be pushed to app repo after it reaches at least 30%
  • If there are existing languages on app repo that are at 34%, but let’s say it drops to 28% because it becomes unmaintained, then new changes should still be pushed (for example, if someone adds new contributions that make it 29%)

@keunes
Copy link
Contributor

keunes commented Nov 10, 2024

We've just moved https://github.com/AntennaPod/AntennaPod app translations from Transifex to Weblate (in addition to the website translations which were already on Weblate). On Transifex we had set a threshold of 40% for app translations.

I get the part about everything being in git. However, maybe there's a way that for example when making merge/pull requests those are made from a branch that only includes the complete translations.

We would support an approach like this - our intention is to have Weblate create PRs from https://hosted.weblate.org/git/antennapod/app/ to https://github.com/AntennaPod/AntennaPod/tree/develop. If we could set the threshold for these PRs, that'd be great :-)

@nijel
Copy link
Member

nijel commented Nov 20, 2024

@keunes That goes more in the direction of #5563.

How about storing the incomplete translations in the repository, but with a different file name/path so that they are not discovered by the framework?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship.
Projects
None yet
Development

No branches or pull requests

5 participants