Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the special-sauce malloc implementation? #11

Open
FredrikLindgren opened this issue Jan 24, 2019 · 0 comments
Open

Remove the special-sauce malloc implementation? #11

FredrikLindgren opened this issue Jan 24, 2019 · 0 comments

Comments

@FredrikLindgren
Copy link
Member

Elkhound et al. is normally linked with the no-op implementation smbase/malloc_stub.c of ckheap.h. Supposedly smbase/malloc.c (conventional and/or customised malloc + ckheap) is good for testing, or something, but a comment in smbase/Makefile.in describes it as being non-functional on Cygwin and OS X.

Given that the default is no-op, it should be safe to remove the lot of it (ckheap.h, malloc.c, malloc_stub.c, testmalloc.c and tmalloc.c) if there is no compelling reason for retaining the special-sauce implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant