chore: Change file scoped namespaces and cleanup job (open-feature#453)

<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->

## This PR
<!-- add the description of the PR here -->

This pull request introduces a significant refactor to the codebase by
converting all namespace declarations to file-scoped namespaces and
updating the `.editorconfig` to enforce this style. Additionally, it
simplifies the structure of multiple files by removing unnecessary
closing braces for namespace blocks.

### Namespace Refactoring:
* Converted all namespace declarations in the `src/OpenFeature`
directory to file-scoped namespaces for consistency and improved
readability. This change affects multiple files, including `Api.cs`,
`Constants.cs`, `Error/*.cs`, `EventExecutor.cs`, and `Extension/*.cs`.
[[1]](diffhunk://#diff-dc150fbd3b7be797470374ee7e38c7ab8a31eb9b6b7a52345e05114c2d32a15eL12-R13)
[[2]](diffhunk://#diff-b0112a803c4d4783b4b829626b4970801bda0de261d9887d3d5f5de30eb49d4fL1-L9)
[[3]](diffhunk://#diff-08c95bef1c40daf926c6da5657e9333d4481a1e76b03c8749b87e58d9c711af3L3-R4)
[[4]](diffhunk://#diff-95f94f0d86864094b6a4ed191b7a08bc306c6b2f21eb061b7de319aa9fa19e3fL1-R2)
[[5]](diffhunk://#diff-591e2f16844f704f064cbe31b7427e66c6f816f421a970fc7ad6fe1ad3c4c220L1-R2)R1,
[[6]](diffhunk://#diff-04e7c0ae5d31a3d10742b06dd413c512ee002ce27ce7b3b39cca79598c381a68L3-R4)
[[7]](diffhunk://#diff-0c85dcfcfa3c97d37ee0ba4394ca6958a14c013ee0940aaea09cefd2686bf41fL1-R2)
[[8]](diffhunk://#diff-a7a382f3d0da52015d1b9e03802692a86c61e7b57580747f31fae37d8dcc5cd6L4-R5)
[[9]](diffhunk://#diff-b9fdde9b61e62d7c474069ea5fc2a43d123ab86d93cb9a6d0673254a64536722L5-R6)
[[10]](diffhunk://#diff-bb4aadb03ea44e3b6b74b83f12b2b1a258e13836bcf815f996addcd5537a478fL5-R6)
[[11]](diffhunk://#diff-89efe60a8b640cc303a38e5b01bc27ad40599e364ff2654a57b7e42138056cdaL5-R6)
[[12]](diffhunk://#diff-7a8cbfba7673f1b69d3d927f60eb4ab0aa548403a118fad9eb43b9a22875dc02L5-R6)
[[13]](diffhunk://#diff-48ae8447bc31a75ecf4bba768a7b68244fbbc9dd5480db9114d9c74fb10fe2efL5-R6)
[[14]](diffhunk://#diff-9a3b5bf7bf3351a6161fc6dd75830bfbaab7aca730cf3f0ae6cd120a76b2f1b1L5-R6)
[[15]](diffhunk://#diff-c4388b2e7252e2e3ac0967dbfdd4647a924cdfc54da229667a0db3613b243a7eL5-R6)
[[16]](diffhunk://#diff-44c88ae43caf99ee733ec911fa85454a96c57d07fc57d2fadd44e12cd7d31cd4L5-R6)
[[17]](diffhunk://#diff-f563baadcf750bb66efaea76d7ec4783320e6efdc45c468effb531c948a2292cL10-R11)
[[18]](diffhunk://#diff-f94bf65f426e13a14f798a8db21a5c9dd3306f5941bde1aba79af3e41421bfc0L5-R6)
[[19]](diffhunk://#diff-484832cfacaa02b6872a26cf5202843e96e0125281deca5798974879d9d609a0L3-R4)

### Code Style Enforcement:
* Updated `.editorconfig` to include a new rule
(`csharp_style_namespace_declarations = file_scoped:warning`) to enforce
the use of file-scoped namespaces.

### Simplification of Code Structure:
* Removed unnecessary closing braces for namespace blocks in all
affected files, as they are no longer required with file-scoped
namespaces. This change simplifies the code and reduces visual clutter.
[[1]](diffhunk://#diff-dc150fbd3b7be797470374ee7e38c7ab8a31eb9b6b7a52345e05114c2d32a15eL369)
[[2]](diffhunk://#diff-b0112a803c4d4783b4b829626b4970801bda0de261d9887d3d5f5de30eb49d4fL1-L9)
[[3]](diffhunk://#diff-08c95bef1c40daf926c6da5657e9333d4481a1e76b03c8749b87e58d9c711af3L56)
[[4]](diffhunk://#diff-95f94f0d86864094b6a4ed191b7a08bc306c6b2f21eb061b7de319aa9fa19e3fL25)
[[5]](diffhunk://#diff-591e2f16844f704f064cbe31b7427e66c6f816f421a970fc7ad6fe1ad3c4c220L28)
[[6]](diffhunk://#diff-04e7c0ae5d31a3d10742b06dd413c512ee002ce27ce7b3b39cca79598c381a68L36)
[[7]](diffhunk://#diff-0c85dcfcfa3c97d37ee0ba4394ca6958a14c013ee0940aaea09cefd2686bf41fL50)
[[8]](diffhunk://#diff-a7a382f3d0da52015d1b9e03802692a86c61e7b57580747f31fae37d8dcc5cd6L29)
[[9]](diffhunk://#diff-b9fdde9b61e62d7c474069ea5fc2a43d123ab86d93cb9a6d0673254a64536722L23)
[[10]](diffhunk://#diff-bb4aadb03ea44e3b6b74b83f12b2b1a258e13836bcf815f996addcd5537a478fL23)
[[11]](diffhunk://#diff-89efe60a8b640cc303a38e5b01bc27ad40599e364ff2654a57b7e42138056cdaL23)
[[12]](diffhunk://#diff-7a8cbfba7673f1b69d3d927f60eb4ab0aa548403a118fad9eb43b9a22875dc02L23)
[[13]](diffhunk://#diff-48ae8447bc31a75ecf4bba768a7b68244fbbc9dd5480db9114d9c74fb10fe2efL23)
[[14]](diffhunk://#diff-9a3b5bf7bf3351a6161fc6dd75830bfbaab7aca730cf3f0ae6cd120a76b2f1b1L23)
[[15]](diffhunk://#diff-c4388b2e7252e2e3ac0967dbfdd4647a924cdfc54da229667a0db3613b243a7eL23)
[[16]](diffhunk://#diff-44c88ae43caf99ee733ec911fa85454a96c57d07fc57d2fadd44e12cd7d31cd4L23)
[[17]](diffhunk://#diff-f563baadcf750bb66efaea76d7ec4783320e6efdc45c468effb531c948a2292cL356)
[[18]](diffhunk://#diff-f94bf65f426e13a14f798a8db21a5c9dd3306f5941bde1aba79af3e41421bfc0L16)
[[19]](diffhunk://#diff-484832cfacaa02b6872a26cf5202843e96e0125281deca5798974879d9d609a0L13)

### Related Issues
<!-- add here the GitHub issue that this PR resolves if applicable -->

Fixes open-feature#447 

### Notes
<!-- any additional notes for this PR -->

I ran the `dotnet format OpenFeature.sln` to clean up the code. As you
can imagine, this generates a big diff. I would advise enabling `Hide
Whitespace` to review this PR, since it will show the conversion from
nested to file namespaces.

---------

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

Author: askpt

.editorconfig

@@ -148,6 +148,9 @@ dotnet_diagnostic.RS0041.severity = suggestion
 # CA2007: Do not directly await a Task
 dotnet_diagnostic.CA2007.severity = error
 
+# IDE0161: Convert to file-scoped namespace
+csharp_style_namespace_declarations = file_scoped:warning
+
 [obj/**.cs]
 generated_code = true
 

src/OpenFeature/Api.cs

@@ -1,9 +1,8 @@
-namespace OpenFeature.Constant
+namespace OpenFeature.Constant;
+
+internal static class NoOpProvider
 {
-    internal static class NoOpProvider
-    {
-        public const string NoOpProviderName = "No-op Provider";
-        public const string ReasonNoOp = "No-op";
-        public const string Variant = "No-op";
-    }
+    public const string NoOpProviderName = "No-op Provider";
+    public const string ReasonNoOp = "No-op";
+    public const string Variant = "No-op";
 }

src/OpenFeature/Constant/Constants.cs

@@ -1,56 +1,55 @@
 using System.ComponentModel;
 
-namespace OpenFeature.Constant
+namespace OpenFeature.Constant;
+
+/// <summary>
+/// These errors are used to indicate abnormal execution when evaluation a flag
+/// </summary>
+/// <seealso href="https://github.com/open-feature/spec/blob/v0.5.2/specification/sections/02-providers.md#requirement-227"/>
+public enum ErrorType
 {
     /// <summary>
-    /// These errors are used to indicate abnormal execution when evaluation a flag
-    /// </summary>
-    /// <seealso href="https://github.com/open-feature/spec/blob/v0.5.2/specification/sections/02-providers.md#requirement-227"/>
-    public enum ErrorType
-    {
-        /// <summary>
-        /// Default value, no error occured
-        /// </summary>
-        None,
-
-        /// <summary>
-        /// Provider has yet been initialized
-        /// </summary>
-        [Description("PROVIDER_NOT_READY")] ProviderNotReady,
-
-        /// <summary>
-        /// Provider was unable to find the flag
-        /// </summary>
-        [Description("FLAG_NOT_FOUND")] FlagNotFound,
-
-        /// <summary>
-        /// Provider failed to parse the flag response
-        /// </summary>
-        [Description("PARSE_ERROR")] ParseError,
-
-        /// <summary>
-        /// Request type does not match the expected type
-        /// </summary>
-        [Description("TYPE_MISMATCH")] TypeMismatch,
-
-        /// <summary>
-        /// Abnormal execution of the provider
-        /// </summary>
-        [Description("GENERAL")] General,
-
-        /// <summary>
-        /// Context does not satisfy provider requirements.
-        /// </summary>
-        [Description("INVALID_CONTEXT")] InvalidContext,
-
-        /// <summary>
-        /// Context does not contain a targeting key and the provider requires one.
-        /// </summary>
-        [Description("TARGETING_KEY_MISSING")] TargetingKeyMissing,
-
-        /// <summary>
-        /// The provider has entered an irrecoverable error state.
-        /// </summary>
-        [Description("PROVIDER_FATAL")] ProviderFatal,
-    }
+    /// Default value, no error occured
+    /// </summary>
+    None,
+
+    /// <summary>
+    /// Provider has yet been initialized
+    /// </summary>
+    [Description("PROVIDER_NOT_READY")] ProviderNotReady,
+
+    /// <summary>
+    /// Provider was unable to find the flag
+    /// </summary>
+    [Description("FLAG_NOT_FOUND")] FlagNotFound,
+
+    /// <summary>
+    /// Provider failed to parse the flag response
+    /// </summary>
+    [Description("PARSE_ERROR")] ParseError,
+
+    /// <summary>
+    /// Request type does not match the expected type
+    /// </summary>
+    [Description("TYPE_MISMATCH")] TypeMismatch,
+
+    /// <summary>
+    /// Abnormal execution of the provider
+    /// </summary>
+    [Description("GENERAL")] General,
+
+    /// <summary>
+    /// Context does not satisfy provider requirements.
+    /// </summary>
+    [Description("INVALID_CONTEXT")] InvalidContext,
+
+    /// <summary>
+    /// Context does not contain a targeting key and the provider requires one.
+    /// </summary>
+    [Description("TARGETING_KEY_MISSING")] TargetingKeyMissing,
+
+    /// <summary>
+    /// The provider has entered an irrecoverable error state.
+    /// </summary>
+    [Description("PROVIDER_FATAL")] ProviderFatal,
 }

src/OpenFeature/Constant/ErrorType.cs

@@ -1,25 +1,24 @@
-namespace OpenFeature.Constant
+namespace OpenFeature.Constant;
+
+/// <summary>
+/// The ProviderEventTypes enum represents the available event types of a provider.
+/// </summary>
+public enum ProviderEventTypes
 {
     /// <summary>
-    /// The ProviderEventTypes enum represents the available event types of a provider.
+    /// ProviderReady should be emitted by a provider upon completing its initialisation.
     /// </summary>
-    public enum ProviderEventTypes
-    {
-        /// <summary>
-        /// ProviderReady should be emitted by a provider upon completing its initialisation.
-        /// </summary>
-        ProviderReady,
-        /// <summary>
-        /// ProviderError should be emitted by a provider upon encountering an error.
-        /// </summary>
-        ProviderError,
-        /// <summary>
-        /// ProviderConfigurationChanged should be emitted by a provider when a flag configuration has been changed.
-        /// </summary>
-        ProviderConfigurationChanged,
-        /// <summary>
-        /// ProviderStale should be emitted by a provider when it goes into the stale state.
-        /// </summary>
-        ProviderStale
-    }
+    ProviderReady,
+    /// <summary>
+    /// ProviderError should be emitted by a provider upon encountering an error.
+    /// </summary>
+    ProviderError,
+    /// <summary>
+    /// ProviderConfigurationChanged should be emitted by a provider when a flag configuration has been changed.
+    /// </summary>
+    ProviderConfigurationChanged,
+    /// <summary>
+    /// ProviderStale should be emitted by a provider when it goes into the stale state.
+    /// </summary>
+    ProviderStale
 }

src/OpenFeature/Constant/EventType.cs

@@ -1,28 +1,27 @@
-namespace OpenFeature.Constant
+namespace OpenFeature.Constant;
+
+/// <summary>
+///  Used to identity what object type of flag being evaluated
+/// </summary>
+public enum FlagValueType
 {
     /// <summary>
-    ///  Used to identity what object type of flag being evaluated
+    /// Flag is a boolean value
     /// </summary>
-    public enum FlagValueType
-    {
-        /// <summary>
-        /// Flag is a boolean value
-        /// </summary>
-        Boolean,
+    Boolean,
 
-        /// <summary>
-        /// Flag is a string value
-        /// </summary>
-        String,
+    /// <summary>
+    /// Flag is a string value
+    /// </summary>
+    String,
 
-        /// <summary>
-        /// Flag is a numeric value
-        /// </summary>
-        Number,
+    /// <summary>
+    /// Flag is a numeric value
+    /// </summary>
+    Number,
 
-        /// <summary>
-        /// Flag is a structured value
-        /// </summary>
-        Object
-    }
+    /// <summary>
+    /// Flag is a structured value
+    /// </summary>
+    Object
 }

src/OpenFeature/Constant/FlagValueType.cs

@@ -1,36 +1,35 @@
 using System.ComponentModel;
 
-namespace OpenFeature.Constant
+namespace OpenFeature.Constant;
+
+/// <summary>
+/// The state of the provider.
+/// </summary>
+/// <seealso href="https://github.com/open-feature/spec/blob/main/specification/sections/02-providers.md#requirement-242" />
+public enum ProviderStatus
 {
     /// <summary>
-    /// The state of the provider.
+    /// The provider has not been initialized and cannot yet evaluate flags.
     /// </summary>
-    /// <seealso href="https://github.com/open-feature/spec/blob/main/specification/sections/02-providers.md#requirement-242" />
-    public enum ProviderStatus
-    {
-        /// <summary>
-        /// The provider has not been initialized and cannot yet evaluate flags.
-        /// </summary>
-        [Description("NOT_READY")] NotReady,
+    [Description("NOT_READY")] NotReady,
 
-        /// <summary>
-        /// The provider is ready to resolve flags.
-        /// </summary>
-        [Description("READY")] Ready,
+    /// <summary>
+    /// The provider is ready to resolve flags.
+    /// </summary>
+    [Description("READY")] Ready,
 
-        /// <summary>
-        /// The provider's cached state is no longer valid and may not be up-to-date with the source of truth.
-        /// </summary>
-        [Description("STALE")] Stale,
+    /// <summary>
+    /// The provider's cached state is no longer valid and may not be up-to-date with the source of truth.
+    /// </summary>
+    [Description("STALE")] Stale,
 
-        /// <summary>
-        /// The provider is in an error state and unable to evaluate flags.
-        /// </summary>
-        [Description("ERROR")] Error,
+    /// <summary>
+    /// The provider is in an error state and unable to evaluate flags.
+    /// </summary>
+    [Description("ERROR")] Error,
 
-        /// <summary>
-        /// The provider has entered an irrecoverable error state.
-        /// </summary>
-        [Description("FATAL")] Fatal,
-    }
+    /// <summary>
+    /// The provider has entered an irrecoverable error state.
+    /// </summary>
+    [Description("FATAL")] Fatal,
 }

src/OpenFeature/Constant/ProviderStatus.cs

@@ -1,50 +1,49 @@
-namespace OpenFeature.Constant
+namespace OpenFeature.Constant;
+
+/// <summary>
+/// Common reasons used during flag resolution
+/// </summary>
+/// <seealso href="https://github.com/open-feature/spec/blob/v0.5.2/specification/sections/02-providers.md#requirement-225">Reason Specification</seealso>
+public static class Reason
 {
     /// <summary>
-    /// Common reasons used during flag resolution
-    /// </summary>
-    /// <seealso href="https://github.com/open-feature/spec/blob/v0.5.2/specification/sections/02-providers.md#requirement-225">Reason Specification</seealso>
-    public static class Reason
-    {
-        /// <summary>
-        /// Use when the flag is matched based on the evaluation context user data
-        /// </summary>
-        public const string TargetingMatch = "TARGETING_MATCH";
-
-        /// <summary>
-        /// Use when the flag is matched based on a split rule in the feature flag provider
-        /// </summary>
-        public const string Split = "SPLIT";
-
-        /// <summary>
-        /// Use when the flag is disabled in the feature flag provider
-        /// </summary>
-        public const string Disabled = "DISABLED";
-
-        /// <summary>
-        /// Default reason when evaluating flag
-        /// </summary>
-        public const string Default = "DEFAULT";
-
-        /// <summary>
-        /// The resolved value is static (no dynamic evaluation)
-        /// </summary>
-        public const string Static = "STATIC";
-
-        /// <summary>
-        /// The resolved value was retrieved from cache
-        /// </summary>
-        public const string Cached = "CACHED";
-
-        /// <summary>
-        /// Use when an unknown reason is encountered when evaluating flag.
-        /// An example of this is if the feature provider returns a reason that is not defined in the spec
-        /// </summary>
-        public const string Unknown = "UNKNOWN";
-
-        /// <summary>
-        /// Use this flag when abnormal execution is encountered.
-        /// </summary>
-        public const string Error = "ERROR";
-    }
+    /// Use when the flag is matched based on the evaluation context user data
+    /// </summary>
+    public const string TargetingMatch = "TARGETING_MATCH";
+
+    /// <summary>
+    /// Use when the flag is matched based on a split rule in the feature flag provider
+    /// </summary>
+    public const string Split = "SPLIT";
+
+    /// <summary>
+    /// Use when the flag is disabled in the feature flag provider
+    /// </summary>
+    public const string Disabled = "DISABLED";
+
+    /// <summary>
+    /// Default reason when evaluating flag
+    /// </summary>
+    public const string Default = "DEFAULT";
+
+    /// <summary>
+    /// The resolved value is static (no dynamic evaluation)
+    /// </summary>
+    public const string Static = "STATIC";
+
+    /// <summary>
+    /// The resolved value was retrieved from cache
+    /// </summary>
+    public const string Cached = "CACHED";
+
+    /// <summary>
+    /// Use when an unknown reason is encountered when evaluating flag.
+    /// An example of this is if the feature provider returns a reason that is not defined in the spec
+    /// </summary>
+    public const string Unknown = "UNKNOWN";
+
+    /// <summary>
+    /// Use this flag when abnormal execution is encountered.
+    /// </summary>
+    public const string Error = "ERROR";
 }