Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Umbrella Header imports do not match content of public header directory include #1314

Open
ch-one opened this issue May 7, 2021 · 0 comments · May be fixed by #1315
Open

Umbrella Header imports do not match content of public header directory include #1314

ch-one opened this issue May 7, 2021 · 0 comments · May be fixed by #1315

Comments

@ch-one
Copy link

ch-one commented May 7, 2021

Xcode 12.5 produces warnings about missing imports in umbrella header FSCalendar.h when using FSCalendar via SPM.
In our project, we treat swift warnings as errors for releases. Therefore our build pipeline won't succeed.

The following screenshot shows the errors produced by Xcode:
fscalendar-missing-includes

It looks like not all of the header files linked in the include directory, need to be public, but only the ones already imported in FSCalendar.h.

I'll create a pull request. Please have a look.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed private headers from include directory ch-one/FSCalendar
1 participant
@ch-one