Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekscope: change month scrollView only when month changes #187

Closed
benrudhart opened this issue Jan 13, 2016 · 11 comments
Closed

Weekscope: change month scrollView only when month changes #187

benrudhart opened this issue Jan 13, 2016 · 11 comments

Comments

@benrudhart
Copy link

I'm using the .Week scope in a horizontal calendar like this.

calendar.scope = .Week
calendar.scrollDirection = .Horizontal

Is there a way to avoid the repetition of month cells and scroll the upper collectionView only when the month changes (see screenshot)? Currently the month collectionView scrolls every time the week collectionView gets scrolled. But this information is somewhat redundant and confusing to a user.
Am I missing an option or is this not yet possible?
screen shot 2016-01-13 at 17 38 10

@WenchaoD
Copy link
Owner

So far I cannot find a reason to do this. Thanks still.

@notDanish
Copy link

@WenchaoD I think this is a real issue. I'm facing it right now and another developer I know had this in the past

@benrudhart
Copy link
Author

@notDanish have a look at this PR:
#189

I already implemented this behavior. Unfortunately the PR was not accepted...

@notDanish
Copy link

@benrudhart you're the man

@benrudhart
Copy link
Author

@WenchaoD I'd kindly like to ask you to consider accepting my PR again. Obviously there are more people looking for a solution like this...

@WenchaoD
Copy link
Owner

The idea is good, but I still feel this wierd.

screen shot 2016-02-25 at 15 19 15

I think the indicator of current month should always stop in the center. Let's discuss

@notDanish
Copy link

@WenchaoD the issue isn't the current month stopping in the center. The issue is the month label scrolling every time you scroll calendar in week scope. What @benrudhart tried to do is that he made the month label scroll only when the month really changed (in Week scope obviously). The month label (header label) can be made to center...that's not hard...but yeah basically you should add this feature. It's worth it....

@WenchaoD
Copy link
Owner

@benrudhart I'm just saying why I didn't accept the pr, not about the issus.
You want to try this?

@benrudhart
Copy link
Author

@WenchaoD sure thing: it's even easier to make month labels always stop centered. But to me it feels weird when there days from several month (e.g. 29, 30, 31, 1, 2 ... ) are visible in the displayed week while only one month is shown... This gets even more crazy when you think about scrolling from right to left and the other way around: one time you end up with another month sticking in the header than when coming from the other side... My current implementation makes sure that the displayed month(s) are always the same - independent of scroll direction and velocity...

@WenchaoD
Copy link
Owner

The current implementation is the middle day of the visible row determine the month header, which comes from this issue

@Neirys
Copy link

Neirys commented Feb 15, 2018

Is this feature will be reconsider any time soon ? I'm facing it right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@benrudhart @notDanish @WenchaoD @Neirys and others