Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date number height is shortened #486

Closed
sashalondon opened this issue Nov 17, 2016 · 7 comments
Closed

Date number height is shortened #486

sashalondon opened this issue Nov 17, 2016 · 7 comments

Comments

@sashalondon
Copy link

I have the installed the chart and it works well. One one view it works perfectly. On another it was working perfectly then suddenly it has an issue that the number for the date row is short. I have increased the height of the calendar and that doesnt matter. I have changed so many settings but it doesnt change. The other view I have works well though. I have enclosed an image of what I mean.

Xcode 8.0 Swift 3 (worked after updating but now doesnt).

glass

How can I change this height?

@WenchaoD
Copy link
Owner

@sashalondon Can you share a demo for this?

@bmc410
Copy link

bmc410 commented Nov 17, 2016

I have the same problem with the version pulled using cocoaPods. Using the swift example provided in the download, setting the height constraint of the calendar control to 200 and all the fonts to 16, the calendar resizes itself nicely in week view at run time. However when starting a new project and using cocoaPods with the same settings as above the control does not resize, it stays the same height and occupies the full height setting. Setting it to anything less than 200 cuts off the data row. Seems as if the boundingRectWillChange delegate is not getting called.

@bmc410
Copy link

bmc410 commented Nov 17, 2016

Never mind, previous comment, I didn't have the delegate hooked up correctly. The control is working beautifully for me now. Thank you.

@sashalondon
Copy link
Author

Hi I have made you a contributor on the project. Please dont be disgusted with the code I am still learning.

Its the plopViewController (the initial view you load).

@WenchaoD
Copy link
Owner

@sashalondon You can send it to my gmail if there is a confidential issue.

@sashalondon
Copy link
Author

The file is quite large (Derived Data is large after deletion). I have sent a file to you.

@sashalondon
Copy link
Author

Your example helped clear this up. Specifically the method:

func calendar(_ calendar: FSCalendar, boundingRectWillChange bounds: CGRect, animated: Bool) {
    self.calendarHeightConstraint.constant = bounds.height
    self.view.layoutIfNeeded()
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants