Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The performance on SYN on FPL #1

Open
AtsuMiyai opened this issue Jun 26, 2023 · 10 comments
Open

The performance on SYN on FPL #1

AtsuMiyai opened this issue Jun 26, 2023 · 10 comments

Comments

@AtsuMiyai
Copy link

Thank you for sharing the code for this very interesting work.

I tried to reproduce your FPL.
It generally worked, but I could not reproduce only the SYN dataset for Digits. The results in Table 2 of the paper report a score of 61.20, but in my multiple replication experiments I only got about 44.1. (43.8 in FedAVG.)

I have a few questions.

Is the data set for SYN this url, right?
Also, when I increased the number of data in the dataset from 1% to 1.5%, the results were comparable to the paper's score. Is there any other solution besides increasing the data?

We apologize for any inconvenience caused. Thank you for your cooperation.

@AtsuMiyai AtsuMiyai changed the title The performance on SYS on FPL The performance on SYN on FPL Jun 26, 2023
@WenkeHuang
Copy link
Owner

Do the counterparts work consistently?
I just check the results:
30 FedProx para1 98.11 90.24 77.01 56.66 80.505
44 FPL InfoT 0.02 98.31 92.71 80.27 61.2 83.1225

@AtsuMiyai
Copy link
Author

Thanks for quick response!

My results on office+caltech seem correct.
My results on Digits seems different from original ones:
FPL: 96.74, 92.97, 87.2, 44.1

For datasets, I download SYN via this url and I use other datasets (e.g., MNIST) automatically downloaded via your code.

I change the argument in main.py as follows:
--dataset fl_digits --rand_dataset=False --parti_num 20
The clients are
Counter({'usps': 7, 'svhn': 6, 'syn': 4, 'mnist': 3})

@WenkeHuang
Copy link
Owner

The SVHN dataset link is: http://ufldl.stanford.edu/housenumbers/
Format 2: Cropped Digits
I will add the datasets in the onedrive.

@AtsuMiyai
Copy link
Author

The SVHN dataset link is: http://ufldl.stanford.edu/housenumbers/

Yes. I use the same ones named train_32x32.mat and test_32x32.mat.

I will add the datasets in the onedrive.

Thanks. I will try with these datasets!

@WenkeHuang
Copy link
Owner

@WenkeHuang
Copy link
Owner

--rand_dataset=True, We made a typing error in the uploading code. The code is based on the seed = 0 and {'mnist': 6, 'syn': 7, 'usps': 4, 'svhn': 3}.

@AtsuMiyai
Copy link
Author

Thanks for the modification. But, I still have difficulty reproducing the results on digits...

I may be doing something wrong, so I'll try some times later.

@YutoShibata07
Copy link

@AtsuMiyai
Could you tell me how you trained your model?
I'm now trying to reproduce the results like you, but it seems a local update part is not working currently.

At utils/training.py
def loc_update(self, priloader_list): pass

Thanks in advance.

@zekunshi
Copy link
Collaborator

zekunshi commented Aug 17, 2023

@YutoShibata07
You may use the fuction in sub-class(like fedavg.py) but not superclass.

@ennnjoy123
Copy link

ennnjoy123 commented Oct 26, 2023

--rand_dataset=True, We made a typing error in the uploading code. The code is based on the seed = 0 and {'mnist': 6, 'syn': 7, 'usps': 4, 'svhn': 3}.

Thank you for your code, So it means that the results for the Digits task reported in your paper are based on: MNIST: 6, USPS: 7, SVHN: 4 and SYN: 3 setting, Not MNIST: 3, USPS: 7, SVHN: 6 and SYN: 4?

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@ennnjoy123 @WenkeHuang @zekunshi @YutoShibata07 @AtsuMiyai and others