New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: replying should be implemented on an Event #59

Open

2 tasks

Wenzel opened this issue Feb 15, 2020 · 0 comments

Labels

Owner

Wenzel commented Feb 15, 2020 •

edited

Loading

It's more natural to call reply on an Event than on the driver:

// old
drv.reply_event(&ev, EventReplyType::Continue)
// new
ev.reply(EventReplyType::Continue)

find a way to hide the API reply_event in the Introspectable trait
expose a new API in impl Event, so users should call this API instead

related: https://github.com/Wenzel/libmicrovmi/pull/49/files

thoughts @kylerky, @rageagainsthepc ?

The text was updated successfully, but these errors were encountered:

Wenzel added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment