Skip to content

Commit 4011b35

Browse files
committed
drm/panic: remove spurious empty line to clean warning
Clippy in the upcoming Rust 1.83.0 spots a spurious empty line since the `clippy::empty_line_after_doc_comments` warning is now enabled by default given it is part of the `suspicious` group [1]: error: empty line after doc comment --> drivers/gpu/drm/drm_panic_qr.rs:931:1 | 931 | / /// They must remain valid for the duration of the function call. 932 | | | |_ 933 | #[no_mangle] 934 | / pub unsafe extern "C" fn drm_panic_qr_generate( 935 | | url: *const i8, 936 | | data: *mut u8, 937 | | data_len: usize, ... | 940 | | tmp_size: usize, 941 | | ) -> u8 { | |_______- the comment documents this function | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments = note: `-D clippy::empty-line-after-doc-comments` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::empty_line_after_doc_comments)]` = help: if the empty line is unintentional remove it Thus remove the empty line. Cc: stable@vger.kernel.org Fixes: cb5164a ("drm/panic: Add a QR code panic screen") Link: rust-lang/rust-clippy#13091 [1] Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com> Link: https://lore.kernel.org/r/20241125233332.697497-1-ojeda@kernel.org Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
1 parent fac04ef commit 4011b35

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/gpu/drm/drm_panic_qr.rs

-1
Original file line numberDiff line numberDiff line change
@@ -929,7 +929,6 @@ impl QrImage<'_> {
929929
/// * `tmp` must be valid for reading and writing for `tmp_size` bytes.
930930
///
931931
/// They must remain valid for the duration of the function call.
932-
933932
#[no_mangle]
934933
pub unsafe extern "C" fn drm_panic_qr_generate(
935934
url: *const i8,

0 commit comments

Comments
 (0)