refactor: golint #303
Merged
refactor: golint #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoank101
requested review from
PolkachuIntern,
faddat,
Sen-Com,
kerber0x,
0xFable and
hieuvubk
as code owners
|
Hey so I like it. I always like to add a linter for rigor, was there anything motivating you to add this particular one? |
faddat
pushed a commit
that referenced
this pull request
Feb 15, 2024
* bump wasm to v0.45.x, cosmos-sdk to v0.47.7, ibc-go to v7.3.0, cometbft to v0.37.4 (#1) * fix: miss go.sum * add miss icq * fix: miss add chainId * chore: add terra core 2.5.0 package * refactor: update Makefile * feat: alliance to 0.3.2 * refactor: update wasm option * feat: update token factory * feat: add upgrade v4.1.0 * refactor: logic upgrade * feat: add script upgrade * fix miss icqtypes * update go.sum * refactor upgrade v4.1.0 * refactor: update UPGRADE_HEIGHT * fix: miss subspace key table * feat: base test framework * chore: remove debug log * chore: update denom in the genesis files * fix: using correct migaloo coin type * test: can init relayer * test: adjust gas and fee doing tx token factory * draft * fix: script unused * chore: remove code not using * fix: rollback go mod * feat: add miss proto * update proto-gen * feat: add feeburn clone from chihuahua * feat: add testutil * refactor: update name convention * refactor: update name convention * feat: add feeburn module to app * feat: add feeburn to upgrade handler * fix: add permission to account fee_collector * chore: add third-party proto * feat: add proposal proto * feat: add proposal types * feat: add handler update * feat: add cli * feat: add handler gov feeburn * test: add ante test * test: refactor app test * feat: add codec handler MsgUpdateTxFeeBurnPercentProposal * refactor: update script * test: update test ante * fix(test): fix cycle import * fix: typo integration test * test: add alliance test * test: ibc hooks * feat: fix ibc hooks * chore: fix update test genesis * fix: ibc callback * test: ibc callback with timeout * fix: register ica controller * test: ica integration test * chore: update make file * refactor: golint (#303) * tidy up go.mod * test: init with 50% feeburn * test: add test upgrade * chore: change name v3 -> v4 * fix: golint * feat: docker setup to run migaloo * feat: docker file to build v3.0.4 * refactor: move v3 code to migalood-env * feat: build cosmovisor migalood env linux images * feat: build linux migalood * feat: init genesis with cosmovisor * feat: setup cosmosvisor to run migalood * feat: base upgrade test * perf: set gas price to 0 stake for test * perf: reduce voting period * chore: get upgrade handler * fix: upgrade name * feat: make file to run test upgrade with multiple nodes * perf: not build if the image is already created * perf: add three more nodes * fix: bump wasmvm to 1.5.1 * refactor: update proto * fix: miss kill old migalood * chore: update go mod * chore: add changelog and update readme * chore: refactor format * feat: add checksum for wasmvm download * refactor: add SetBech32 account * test: remove cmd_test * refactor: go lint * refactor: update go.mod * feat: gen-swagger scripts * feat: add swagger client * chore: add debugger * fix: gen swagger scripts with ns * fix: gen proto with cosmos sdk * fix lint * lint: add space between comment and text * fix: miss burning module permissions * feat: add migrateMultisigVesting * fix lint * update name * default chain_id * remove balance for tx fee * fix: calculate balanceDelegate * fix lint * update logic * chore: miss end line * chore: remove code unused * deps: update golangci version * deps: update golangci version * deps: update golangci version * deps: update wasmvm to v1.5.2 * deps: update dependency * deps: update dependency * deps: update version * chore: skip dependency-review in cosmos-sdk v0.47.x * chore: skip dependency-review in cosmos-sdk v0.47.x * docs: update docs * docs: update docs * docs: update changelog --------- Co-authored-by: kienn6034 <kien@notional.ventures> Co-authored-by: tungle <anhletung@notional.ventures>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.