Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(networks): update genesis.json #9

Merged
merged 8 commits into from
Feb 3, 2023
Merged

Conversation

Sen-Com
Copy link
Contributor

@Sen-Com Sen-Com commented Feb 1, 2023

Description and Motivation

Modifies draft of genesis file


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly go fmt path/to/your/package.

@faddat
Copy link
Collaborator

faddat commented Feb 2, 2023

note: this may need to change a bit because of alliance, not sure.

@faddat
Copy link
Collaborator

faddat commented Feb 2, 2023

to ensure valid:

migalood validate-genesis networks/planning/genesis.json

gn

@Sen-Com Sen-Com marked this pull request as ready for review February 3, 2023 07:36
Copy link
Contributor

@kerber0x kerber0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@kerber0x kerber0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The genesis file looks good, it's valid. Let's add .DS_Store files to .gitignore so we don't get those popping up in our PRs.

@Sen-Com Sen-Com requested a review from kerber0x February 3, 2023 12:38
@Sen-Com Sen-Com merged commit 43c688c into main Feb 3, 2023
@Sen-Com Sen-Com deleted the genesis-modifications branch February 3, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants