Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move documentation to JSDoc #233

Closed
3 of 19 tasks
sasha240100 opened this issue Apr 9, 2017 · 7 comments
Closed
3 of 19 tasks

Move documentation to JSDoc #233

sasha240100 opened this issue Apr 9, 2017 · 7 comments

Comments

@sasha240100
Copy link
Member

There is a JSDoc support for Readme.io - link here

I'd like to see it working with this project. How about moving docs there? It will be easier to maintain them.

Version:
  • v2.x.x
  • v1.x.x
Issue type:
  • Bug
  • Proposal/Enhancement
  • Question
  • Discussion

Tested on:
Desktop
  • Chrome
  • Chrome Canary
  • Chrome dev-channel
  • Firefox
  • Opera
  • Microsoft IE
  • Microsoft Edge
Android
  • Chrome
  • Firefox
  • Opera
IOS
  • Chrome
  • Firefox
  • Opera
@hirako2000
Copy link
Collaborator

Swagger is actually more suited for RESTful APIs than for documenting libraries.

@hirako2000
Copy link
Collaborator

hirako2000 commented Apr 14, 2017

What about using JSDoc and push the generated doc to surge?

@sasha240100
Copy link
Member Author

@hirako2000 Maybe use some integrations to use it for library API ?

@hirako2000
Copy link
Collaborator

@thejmazz , what do you think?

@thejmazz
Copy link
Contributor

I don't think swagger is useful here, as @hirako2000 mentions - it is for documenting REST APIs.

It does seem very useful to have HTML documentation generated from code comments. JSDoc is great, and has a bunch of to-markdown, to-html tools. Maybe something like typedoc would work as well.

I'm curious how whs-specific features (e.g. "this component is compatible with module x", or "module y requires the position and rotation properties on the component") could be generated in an automatic way.

@hirako2000
Copy link
Collaborator

I don't think generated doc is all that useful right now.
probably better put some effort in typings, which give an incentive to provide human readable comment to functions and properties since they are exposed for typescript users.

I suggest we close this for now. provide clearer doc in readme.io where appropriate, more examples & some guides.

The source code ultimately is needed for understanding the core logic to extend certain components and create modules.

@sasha240100 sasha240100 changed the title Move documentation to Swagger Move documentation to JSDoc May 31, 2017
@hirako2000
Copy link
Collaborator

Progress on issue #189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants