Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comply with CommonMark #212

Closed
Witiko opened this issue Nov 11, 2022 · 0 comments · Fixed by #226
Closed

Comply with CommonMark #212

Witiko opened this issue Nov 11, 2022 · 0 comments · Fixed by #226
Assignees
@lostenderman
Labels
commonmark Related to making the syntax of markdown follow the CommonMark spec feature request lua Related to the Lua interface and implementation technical debt Related to code smells and refactoring
Milestone
3.0.0-alpha

Comments

@Witiko
Copy link
Owner

Witiko commented Nov 11, 2022 •
edited
Loading

In #163, we have fixed one of the many differences between our implementation of markdown and the CommonMark spec (version 0.30). More systematically, we would like to have the entire grammar checked against the spec by converting the 652 examples from the spec to unit tests and fixing whatever differences may surface. Merging the result will constitute a major change and should therefore be postponed until the next major version of Markdown. Whereever possible, we should add options to preserve the previous behavior. If possible, we should also offer patches to the jgm/lunamark upstream.
@Witiko Witiko added feature request good first issue lua Related to the Lua interface and implementation technical debt Related to code smells and refactoring commonmark Related to making the syntax of markdown follow the CommonMark spec labels Nov 11, 2022
@Witiko Witiko added this to the 3.0.0 milestone Nov 11, 2022
@Witiko Witiko mentioned this issue Nov 11, 2022
Closed
@Witiko Witiko mentioned this issue Nov 28, 2022
Closed
@Witiko Witiko mentioned this issue Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lostenderman lostenderman

Labels
commonmark Related to making the syntax of markdown follow the CommonMark spec feature request lua Related to the Lua interface and implementation technical debt Related to code smells and refactoring
Projects
None yet
Milestone
3.0.0-alpha
Development

Successfully merging a pull request may close this issue.

Comply with CommonMark 0.30 lostenderman/markdown
Comply with CommonMark lostenderman/markdown
2 participants
@Witiko @lostenderman