Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include thirdparty libraries as submodules #19

Closed
feliwir opened this issue Apr 25, 2022 · 3 comments
Closed

Include thirdparty libraries as submodules #19

feliwir opened this issue Apr 25, 2022 · 3 comments

Comments

@feliwir
Copy link
Contributor

feliwir commented Apr 25, 2022

Hello,
would it be welcome if i include thirdparty libraries as submodules?
It makes managing & versioning a lot simpler and reduces the overall size of the repository. Of course this is only viable if there weren't any customizations done to the libraries.

Most projects (in their unmodified form) can just be compiled by using add_subdirectory - this would probably require updating a few of the dependencies.

@feliwir feliwir changed the title Include libraries as submodules Include thirdparty libraries as submodules Apr 25, 2022
@autious
Copy link
Collaborator

autious commented Apr 25, 2022

There's already a discussion related to this here #15, i suggest adding to that discussion.

@Conan-Kudo
Copy link
Collaborator

Duplicates #15

@Conan-Kudo
Copy link
Collaborator

Duplicate of #15

@Conan-Kudo Conan-Kudo marked this as a duplicate of #15 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants