Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continuous Integration #1078

Open
rfuzzo opened this issue Jan 14, 2023 · 7 comments
Open

Continuous Integration #1078

rfuzzo opened this issue Jan 14, 2023 · 7 comments
Assignees
@zen-v0 @rfuzzo
Labels
epic p1 High priority
Milestone
Backlog

Comments

@rfuzzo
Copy link
Member

rfuzzo commented Jan 14, 2023

[Issue create with https://github.com/rfuzzo/LizzyFuzzy]
Author: rfuzzo
add WolvenKit to winget. Winget supports inno setup out of the box so its just a matter of adding the installer.

Bonus points for adding it to the CI
@rfuzzo rfuzzo self-assigned this Jan 14, 2023
@zen-v0 zen-v0 self-assigned this Jan 14, 2023
@zen-v0
Copy link
Member

zen-v0 commented Jan 14, 2023 •
edited
Loading

You need to file a PR with a generated manifest to add WolvenKit to winget.
I've generated one, but I have a question before I open up a PR with whatever I just generated: Do we link winget to download our installer from a GitHub release? (That'd mean a PR has to be filed in their repo everytime we update the application) - or what's the idea?

@rfuzzo
Copy link
Member Author

rfuzzo commented Jan 14, 2023

You need to file a PR with a generated manifest to add WolvenKit to winget.

I've generated one, but I have a question before I open up a PR with whatever I just generated: Do we link winget to download our installer from a GitHub release? (That'd mean a PR has to be filed in their repo everytime we update the application) - or what's the idea?

Yea the idea is to use the link from GitHub and indeed we need yo make a PR for each update. There are GitHub actions to do this from CI

It also means that we need a separate entry for WolvenKit nightly and separate manifests and PRs.

I don't believe there is another way, but I also don't see the problem really, what do you think?

Also: there is a way to add PackageDependencies to the manifest (NET7) - but winget will only support this at v1.5 or later (I believe winget is at v1.3 or v1.4 right now)

@zen-v0
Copy link
Member

zen-v0 commented Jan 14, 2023

PR for Nightly: microsoft/winget-pkgs#93726

@rfuzzo rfuzzo added epic p1 High priority labels Jan 14, 2023
@rfuzzo rfuzzo added this to the Version-8.8.1 milestone Jan 14, 2023
@rfuzzo
Copy link
Member Author

rfuzzo commented Jan 14, 2023 •
edited
Loading

Todos:

  • Nightly winget PR (REDmodding.WolvenKit-Nightly)
    - [ ] Stable winget PR (REDmodding.WolvenKit)
  • Nightly ci updates winget-nightly
    - [ ] Stable ci updates winget-stable

@rfuzzo rfuzzo pinned this issue Jan 14, 2023
@rfuzzo rfuzzo mentioned this issue Jan 14, 2023
Open
@rfuzzo rfuzzo removed this from the Version-8.8.1 milestone Jan 17, 2023
@zen-v0
Copy link
Member

zen-v0 commented Jan 17, 2023

Nightly PR was merged.

@rfuzzo rfuzzo added this to the Backlog milestone Mar 8, 2023
@rfuzzo rfuzzo changed the title winget Continuous Integration Mar 18, 2023
@rfuzzo
Copy link
Member Author

rfuzzo commented Mar 18, 2023

WolvenKit (Stable) is now on the MS Store: https://apps.microsoft.com/store/detail/wolvenkit/9NPWDMHDXBQ9
So we won't do winget for stable anymore.

Todos:

  • submit updates to the store in github-ci
  • decide if we want the nightly (beta) also on the store (and then remove the nightly from winget)
  • fix the nightly winget ci

@seberoth seberoth mentioned this issue May 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zen-v0 zen-v0

@rfuzzo rfuzzo

Labels
epic p1 High priority
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@zen-v0 @rfuzzo and others