Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying Font Families via theme.json - Lesson #1101

Closed
Tracked by #1041
jonathanbossenger opened this issue Nov 21, 2022 · 3 comments
Closed
Tracked by #1041

Applying Font Families via theme.json - Lesson #1101

jonathanbossenger opened this issue Nov 21, 2022 · 3 comments

Comments

@jonathanbossenger
Copy link
Collaborator

jonathanbossenger commented Nov 21, 2022

IMPORTANT

This lesson plan belongs to part of a greater course, Extend a Low Code Block Theme which depends on the completion of Create a Custom Block Theme #1

Please reach out to @jonathanbossenger (Jonathan Bossenger) in the #training team Slack if you would like to help with this lesson plan.

Topic Description

The goal of this lesson is to learn how to apply font families via theme.json.

Guidelines

Review the [team guidelines] (https://make.wordpress.org/training/handbook/guidelines/)

Review checklist

Reviewers: this is not an extensive list, but it would be helpful if you can keep the following questions in mind while reviewing.

  1. Are there any spelling/grammar issues or anything that doesn't make sense?
  2. Is the content technically correct?
  3. Does the layering of information successfully build from lesson to lesson
  4. Can you follow the steps outlined in the course
  5. Does the lesson contain enough relevant links to documentation (WordPress documentation, or any other relevant documentation)
@jonathanbossenger jonathanbossenger changed the title Applying Font Families via theme.json Applying Font Families via theme.json - Lesson Nov 21, 2022
@westnz
Copy link
Collaborator

westnz commented Nov 23, 2022

Review:

The Heading appears twice:
image

Very practical: "Now, let’s take what you’ve learned and use it to set up font families."

I don't see any assessments for the 'Custom Blocks in Block Themes' module, but I assume it is because of all the practical steps and examples that learners must test out.

@jonathanbossenger
Copy link
Collaborator Author

I don't see any assessments for the 'Custom Blocks in Block Themes' module, but I assume it is because of all the practical steps and examples that learners must test out.

Note, most of the lessons are practical lessons, that learners must follow. But I had also not added any quizzes at the end of each module, by the time you reviewed. Those quizzes are now added. So there are practical steps included in most lessons (except those that are informational) and now quizzes to recap the content at the end of each module.

@jonathanbossenger
Copy link
Collaborator Author

The Heading appears twice:

Good spot, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants