-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review theme requirements - Lesson #868
Comments
Suggested improvements:
|
Hey @westnz, thanks for the review feedback
There is actually already a start of an introduction here, but I plan to revise it once the first 4 modules are complete.
Sadly this is one limitation of making this available for early review via GitHub, we don't have the same tooltips/callouts that we do on Learn. However, I plan to use the same callouts with different icons/colors that @wparasae is using for her course.
Done, thanks. |
My only piece of feedback when reviewing this is to think about how to incorporate mentioning the Create Block Theme plugin. Perhaps at the end after mentioning all of this requirements, you can mention it as a tool to consider after this:
|
Thanks for the feedback @annezazu One of the early pieces of feedback I received from a developer/training team member when I was putting the outline of this course together is not to rely too much on "external dependencies" for the completion of this course. I tend to agree with that statement, to some degree, and so I'm trying to balance teaching block theme development to someone who just has a local WordPress install, and a text editor, without needing to rely on Create Block Theme. That being said, I'm a big fan of using the plugin myself, so perhaps it would be beneficial to have a discussion about how much one can rely on the plugin being around for the long term, or the functionality eventually being merged into core? |
Very true! I could see this evolving as time goes on and the Site Editor tools themselves become more advanced. At the least, you could mention it and link off to here: https://developer.wordpress.org/themes/basics/tools-resources/ |
Feedback for Module #1 I especially like your use of terminology. Since this is a review, I'm able to make connections between the elementary-level that I understand as a new developer and a more advanced one because of the language you're using. Well done! I have three tiny changes (typos and like... two sentences, basically!)
Option for change: New users might benefit from a tiny bit more explanation about author / theme URI's -- this is not covered in my course, but it could be! If your intended audience already has a strong grasp of this, let me know in a comment in [this link to notes I took on style.css](https://docs.google.com/document/d/18_W7OtGt7O9U2RmReyJ7Z9ZeuqpFznwFw5HPByCooYA/edit? |
@wparasae thank you for your feedback. I've updated the content based on your suggestions. |
IMPORTANT
This lesson plan belongs to part of a greater course, Extend a Low Code Block Theme which depends on the completion of Create a Custom Block Theme #1
Please reach out to @jonathanbossenger (Jonathan Bossenger) in the #training team Slack if you would like to help with this lesson plan.
Topic Description
The goal of this lesson is to review the basic requirements for setting up a new block theme, covering these three lessons from the first course
Objectives
After completing this lesson, participants will have completed a refresher of the basic theme requirements of a block theme.
Guidelines
Review the [team guidelines] (https://make.wordpress.org/training/handbook/guidelines/)
Lesson for review:
Block Theme Requirements: A Review
Review checklist
Reviewers: this is not an extensive list, but it would be helpful if you can keep the following questions in mind while reviewing.
The text was updated successfully, but these errors were encountered: