Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review theme requirements - Lesson #868

Closed
Tracked by #821
jonathanbossenger opened this issue Aug 1, 2022 · 10 comments
Closed
Tracked by #821

Review theme requirements - Lesson #868

jonathanbossenger opened this issue Aug 1, 2022 · 10 comments
Assignees

Comments

@jonathanbossenger
Copy link
Collaborator

jonathanbossenger commented Aug 1, 2022

IMPORTANT

This lesson plan belongs to part of a greater course, Extend a Low Code Block Theme which depends on the completion of Create a Custom Block Theme #1

Please reach out to @jonathanbossenger (Jonathan Bossenger) in the #training team Slack if you would like to help with this lesson plan.

Topic Description

The goal of this lesson is to review the basic requirements for setting up a new block theme, covering these three lessons from the first course

Objectives

After completing this lesson, participants will have completed a refresher of the basic theme requirements of a block theme.

Guidelines

Review the [team guidelines] (https://make.wordpress.org/training/handbook/guidelines/)

Lesson for review:

Block Theme Requirements: A Review

Review checklist

Reviewers: this is not an extensive list, but it would be helpful if you can keep the following questions in mind while reviewing.

  1. Are there any spelling/grammar issues or anything that doesn't make sense?
  2. Is the content technically correct?
  3. Does the layering of information successfully build from lesson to lesson
  4. Can you follow the steps outlined in the course
  5. Does the lesson contain enough relevant links to documentation (WordPress documentation, or any other relevant documentation)
@jonathanbossenger jonathanbossenger added [Content Type] Lesson Plan Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. labels Aug 1, 2022
@jonathanbossenger jonathanbossenger self-assigned this Aug 1, 2022
@jonathanbossenger jonathanbossenger changed the title [Related Course: Extend a Low Code Block Theme] Review theme requirements - Lesson Plan Review theme requirements - Lesson Plan Aug 26, 2022
@jonathanbossenger
Copy link
Collaborator Author

@jonathanbossenger jonathanbossenger added Ready for Review and removed Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. labels Sep 8, 2022
@jonathanbossenger
Copy link
Collaborator Author

Suggested improvements:

  1. Add links to the documentation for more technical information
  2. Link back to the relevant modules on the Create a Block Theme (Low-Code) course

@jonathanbossenger jonathanbossenger added the Priority - High High priority issue. label Sep 12, 2022
@jonathanbossenger jonathanbossenger moved this to 🔎 Review in Progress in LearnWP Content - Development Sep 12, 2022
@jonathanbossenger jonathanbossenger changed the title Review theme requirements - Lesson Plan Review theme requirements - Lesson Sep 21, 2022
@westnz
Copy link
Collaborator

westnz commented Sep 27, 2022

Feedback - Block Theme Requirements: A Review

I assume the introduction to the course is still being developed? I think it is great how you jump straight into the lesson and content. You grab the attention of the learner immediately. I get that feeling of 'let's go!'

The sub-headings are very effective. As a non-developer, even I can follow the requirements step-by-step.

I was wondering if Note and Do (throughout the course) can be in different colours to make them stand out more.
image

I like how you already set up the next lesson at the end.

Spelling
In the first paragraph below theme.json - fix the spelling of useful.

@jonathanbossenger
Copy link
Collaborator Author

jonathanbossenger commented Sep 28, 2022

Hey @westnz, thanks for the review feedback

I assume the introduction to the course is still being developed?

There is actually already a start of an introduction here, but I plan to revise it once the first 4 modules are complete.

I was wondering if Note and Do (throughout the course) can be in different colours to make them stand out more.

Sadly this is one limitation of making this available for early review via GitHub, we don't have the same tooltips/callouts that we do on Learn. However, I plan to use the same callouts with different icons/colors that @wparasae is using for her course.

fix the spelling of useful.

Done, thanks.

@annezazu
Copy link

My only piece of feedback when reviewing this is to think about how to incorporate mentioning the Create Block Theme plugin. Perhaps at the end after mentioning all of this requirements, you can mention it as a tool to consider after this:

You can read more about the minimum requirements for setting up a Block Theme in the section on Block Themes in the Theme Handbook.

@jonathanbossenger
Copy link
Collaborator Author

Thanks for the feedback @annezazu

One of the early pieces of feedback I received from a developer/training team member when I was putting the outline of this course together is not to rely too much on "external dependencies" for the completion of this course.

I tend to agree with that statement, to some degree, and so I'm trying to balance teaching block theme development to someone who just has a local WordPress install, and a text editor, without needing to rely on Create Block Theme.

That being said, I'm a big fan of using the plugin myself, so perhaps it would be beneficial to have a discussion about how much one can rely on the plugin being around for the long term, or the functionality eventually being merged into core?

@annezazu
Copy link

Very true! I could see this evolving as time goes on and the Site Editor tools themselves become more advanced. At the least, you could mention it and link off to here: https://developer.wordpress.org/themes/basics/tools-resources/

@wparasae
Copy link
Collaborator

Feedback for Module #1
I really appreciate how well this first module builds on the beginner-level course I'm working on -- you're definitely covering everything needed, but keeping it brief enough to engage folks who are familiar with this. Bravo!

I especially like your use of terminology. Since this is a review, I'm able to make connections between the elementary-level that I understand as a new developer and a more advanced one because of the language you're using. Well done!

I have three tiny changes (typos and like... two sentences, basically!)

  1. Are there any spelling/grammar issues or anything that doesn't make sense?
    a. Typo: "but it's useful to add data for Theme URI, Author, and Author UR." Author UR needs an I to become "Author URI"

  2. Is the content technically correct?
    Finally, a block theme needs a theme.json file. This file handles the global settings and styles for a block theme. This file is not required for a block theme to be active on a WordPress site, but for development purposes, it's extremely useful to create it early on. This statement is slightly contradictory; consider rewriting.

Option for change: New users might benefit from a tiny bit more explanation about author / theme URI's -- this is not covered in my course, but it could be! If your intended audience already has a strong grasp of this, let me know in a comment in [this link to notes I took on style.css](https://docs.google.com/document/d/18_W7OtGt7O9U2RmReyJ7Z9ZeuqpFznwFw5HPByCooYA/edit?

@jonathanbossenger
Copy link
Collaborator Author

@wparasae thank you for your feedback. I've updated the content based on your suggestions.

@jonathanbossenger
Copy link
Collaborator Author

Repository owner moved this from 🔎 Review in Progress to 📜 Published or Closed in LearnWP Content - Development Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📜 Published or Closed
Development

No branches or pull requests

4 participants