Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is-video class in the editor, is-type-video class in front-end #10121

Closed
samikeijonen opened this issue Sep 23, 2018 · 3 comments · Fixed by #10411
Closed

is-video class in the editor, is-type-video class in front-end #10121

samikeijonen opened this issue Sep 23, 2018 · 3 comments · Fixed by #10411
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended

Comments

@samikeijonen
Copy link
Contributor

samikeijonen commented Sep 23, 2018 •
edited
Loading

Describe the bug
When using Youtube block I see is-video class in the editor, is-type-video class in front-end.

Expected behavior
Should both classes be is-type-video so that styling can be done with the same class in the editor and in the front-end? Or what is the reason for different classes?
@chrisvanpatten
Copy link
Contributor

chrisvanpatten commented Sep 23, 2018 •
edited
Loading

This definitely strikes me as a bug, but it could also be that changing the class in the editor would have triggered a block invalidation error, so perhaps it wasn't changed for that reason? Flagging for feedback!

@chrisvanpatten chrisvanpatten added [Type] Bug An existing feature does not function as intended Needs Technical Feedback Needs testing from a developer perspective. labels Sep 23, 2018
@mcsf
Copy link
Contributor

mcsf commented Sep 25, 2018

From what I could track down, is-video was added in #1554, and then consistent is-type- classes in #4118. I guess they happened without mutual knowledge…?

Anyway, this is worth fixing, probably by extending the editor classes with is-type-* and deprecating is-video.

@mcsf mcsf added [Feature] Blocks Overall functionality of blocks and removed Needs Technical Feedback Needs testing from a developer perspective. labels Sep 25, 2018
@nfmohit nfmohit mentioned this issue Oct 8, 2018
Merged
4 tasks
@nfmohit
Copy link
Member

nfmohit commented Oct 9, 2018

Submitted a PR addressing this issue in #10411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] Establish consistency between front-end and back-end classes for Youtube (Embed) block
4 participants
@mcsf @chrisvanpatten @samikeijonen @nfmohit